You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/21 21:38:22 UTC
Review Request 68457: Updated `upgrades.md`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68457/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Repository: mesos
Description
-------
The upgrade documentation has been updated to reflect the new API
changes in Mesos 1.7. The sorter change has been removed since this is
an internal change.
Diffs
-----
docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
Diff: https://reviews.apache.org/r/68457/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 68457: Updated `upgrades.md`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68457/#review207721
-----------------------------------------------------------
PASS: Mesos patch 68457 was successfully built and tested.
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2214/mesos-review-68457
- Mesos Reviewbot Windows
On Aug. 21, 2018, 9:38 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68457/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:38 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The upgrade documentation has been updated to reflect the new API
> changes in Mesos 1.7. The sorter change has been removed since this is
> an internal change.
>
>
> Diffs
> -----
>
> docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
>
>
> Diff: https://reviews.apache.org/r/68457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68457: Updated `upgrades.md`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Aug. 21, 2018, 10:12 p.m., Benjamin Mahler wrote:
> > Might want to split out the sorter removal when you commit. Did we audit for other api changes? e.g. diff the protobuf files
Sure let me split them.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68457/#review207707
-----------------------------------------------------------
On Aug. 21, 2018, 9:38 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68457/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:38 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The upgrade documentation has been updated to reflect the new API
> changes in Mesos 1.7. The sorter change has been removed since this is
> an internal change.
>
>
> Diffs
> -----
>
> docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
>
>
> Diff: https://reviews.apache.org/r/68457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68457: Updated `upgrades.md`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68457/#review207707
-----------------------------------------------------------
Ship it!
Might want to split out the sorter removal when you commit. Did we audit for other api changes? e.g. diff the protobuf files
- Benjamin Mahler
On Aug. 21, 2018, 9:38 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68457/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:38 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The upgrade documentation has been updated to reflect the new API
> changes in Mesos 1.7. The sorter change has been removed since this is
> an internal change.
>
>
> Diffs
> -----
>
> docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
>
>
> Diff: https://reviews.apache.org/r/68457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68457: Updated `upgrades.md`.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68457/#review207711
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 21, 2018, 2:38 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68457/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 2:38 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The upgrade documentation has been updated to reflect the new API
> changes in Mesos 1.7. The sorter change has been removed since this is
> an internal change.
>
>
> Diffs
> -----
>
> docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
>
>
> Diff: https://reviews.apache.org/r/68457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>