You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/15 17:29:16 UTC
[GitHub] [hadoop] steveloughran opened a new pull request, #5228: HADOOP-18561. Update commons-net to 3.9.0 (#5214)
steveloughran opened a new pull request, #5228:
URL: https://github.com/apache/hadoop/pull/5228
Addresses CVE-2021-37533, which *only* relates to FTP.
Applications not using the ftp:// filesystem, which, as anyone who has used it will know is very minimal and so rarely used, is not a critical part of the project.
Furthermore, the FTP-related issue is at worst information leakage if someone connects to a malicious server.
This is a due diligence PR rather than an emergency fix.
Contributed by Steve Loughran
### Description of PR
branch 3.3.5 pr of #5214
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5228: HADOOP-18561. Update commons-net to 3.9.0 (#5214)
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #5228:
URL: https://github.com/apache/hadoop/pull/5228#issuecomment-1357494688
+1, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #5228: HADOOP-18561. Update commons-net to 3.9.0 (#5214)
Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #5228:
URL: https://github.com/apache/hadoop/pull/5228#issuecomment-1357490698
all test failures bar two in yarn are test timeouts. the yarn two go nowhere near commons-net
```
org.apache.hadoop.yarn.service.TestYarnNativeServices.testAMFailureValidity
Error Details
Message missing required fields: container_id
org.apache.hadoop.thirdparty.protobuf.UninitializedMessageException: Message missing required fields: container_id
at org.apache.hadoop.thirdparty.protobuf.AbstractMessage$Builder.newUninitializedMessageException(AbstractMessage.java:477)
at org.apache.hadoop.yarn.proto.YarnServiceProtos$SignalContainerRequestProto$Builder.build(YarnServiceProtos.java:41521)
at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.SignalContainerRequestPBImpl.mergeLocalToProto(SignalContainerRequestPBImpl.java:83)
at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.SignalContainerRequestPBImpl.getProto(SignalContainerRequestPBImpl.java:63)
at org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl.signalToContainer(ApplicationClientProtocolPBClientImpl.java:622)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433)
at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166)
at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158)
at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96)
at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362)
at com.sun.proxy.$Proxy99.signalToContainer(Unknown Source)
at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.signalToContainer(YarnClientImpl.java:1027)
at org.apache.hadoop.yarn.service.TestYarnNativeServices.testAMFailureValidity(TestYarnNativeServices.java:980)
org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy.testAllocation[Duration 90,000,000, height 0.25, numSubmission 1, periodic 86400000)]
Stack Trace
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.fail(Assert.java:64)
at junit.framework.TestCase.fail(TestCase.java:230)
at org.apache.hadoop.yarn.server.resourcemanager.reservation.BaseSharingPolicyTest.runTest(BaseSharingPolicyTest.java:146)
at org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy.testAllocation(TestCapacityOverTimePolicy.java:136)
at sun.reflect.GeneratedMethodAccessor27.invoke(Unknown Source)
2022-12-18 23:17:03,227 INFO [main] recovery.RMStateStore (RMStateStore.java:transition(591)) - Storing reservation allocation.reservation_2606473794749035376_5181363377075313936
2022-12-18 23:17:03,227 INFO [main] recovery.RMStateStore (MemoryRMStateStore.java:storeReservationState(258)) - Storing reservationallocation for reservation_2606473794749035376_5181363377075313936 for plan dedicated
2022-12-18 23:17:03,227 INFO [main] reservation.InMemoryPlan (InMemoryPlan.java:addReservation(373)) - Successfully added reservation: reservation_2606473794749035376_5181363377075313936 to plan.
In-memory Plan: Parent Queue: dedicated Total Capacity: <memory:1024000, vCores:1000> Step: 1000reservation_2606473794749035376_5181363377075313936 user:u1 startTime: 0 endTime: 86400000 Periodiciy: 86400000 alloc:
[Period: 86400000
0: <memory:256000, vCores:250>
1023216: <memory:0, vCores:0>
83823216: <memory:256000, vCores:250>
86400000: <memory:0, vCores:0>
9223372036854775807: null
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran merged pull request #5228: HADOOP-18561. Update commons-net to 3.9.0 (#5214)
Posted by GitBox <gi...@apache.org>.
steveloughran merged PR #5228:
URL: https://github.com/apache/hadoop/pull/5228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #5228: HADOOP-18561. Update commons-net to 3.9.0 (#5214)
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #5228:
URL: https://github.com/apache/hadoop/pull/5228#issuecomment-1357086582
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +0 :ok: | shelldocs | 0m 0s | | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ branch-3.3.5 Compile Tests _ |
| +0 :ok: | mvndep | 4m 49s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 34m 58s | | branch-3.3.5 passed |
| +1 :green_heart: | compile | 18m 35s | | branch-3.3.5 passed |
| +1 :green_heart: | mvnsite | 20m 56s | | branch-3.3.5 passed |
| +1 :green_heart: | javadoc | 6m 51s | | branch-3.3.5 passed |
| +1 :green_heart: | shadedclient | 31m 5s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 24m 35s | | the patch passed |
| +1 :green_heart: | compile | 18m 3s | | the patch passed |
| -1 :x: | javac | 18m 3s | [/results-compile-javac-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/artifact/out/results-compile-javac-root.txt) | root generated 3 new + 1863 unchanged - 0 fixed = 1866 total (was 1863) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | mvnsite | 20m 35s | | the patch passed |
| +1 :green_heart: | shellcheck | 0m 0s | | No new issues. |
| +1 :green_heart: | javadoc | 6m 45s | | the patch passed |
| +1 :green_heart: | shadedclient | 31m 26s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 756m 12s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/artifact/out/patch-unit-root.txt) | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 25s | | The patch does not generate ASF License warnings. |
| | | 966m 38s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.service.TestYarnNativeServices |
| | hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy |
| | hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore |
| | hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService |
| | hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy |
| | hadoop.hdfs.server.namenode.snapshot.TestSnapshotBlocksMap |
| | hadoop.hdfs.TestFileLengthOnClusterRestart |
| | hadoop.hdfs.TestErasureCodingPolicyWithSnapshot |
| | hadoop.hdfs.TestLeaseRecovery2 |
| | hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion |
| | hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate |
| | hadoop.hdfs.server.namenode.snapshot.TestSnapshot |
| | hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/5228 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs |
| uname | Linux c5ca494709c6 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3.5 / 734436720484d1171178d13a2b145e7a40980003 |
| Default Java | Private Build-1.8.0_352-8u352-ga-1~18.04-b08 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/testReport/ |
| Max. process+thread count | 2155 (vs. ulimit of 5500) |
| modules | C: hadoop-project . U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5228/2/console |
| versions | git=2.17.1 maven=3.6.0 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org