You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/05/30 06:08:20 UTC
[GitHub] [incubator-devlake] likyh opened a new pull request, #2030: add migration for directrun; update feishu model
likyh opened a new pull request, #2030:
URL: https://github.com/apache/incubator-devlake/pull/2030
# Summary
copy migrate from `services/init.go` to `directrun.go` for migration in cli;
delete `id` in feishu model and add new primaryKey
### Does this close any open issues?
close #2029
close #2014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #2030: add migration for directrun; update feishu model
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #2030:
URL: https://github.com/apache/incubator-devlake/pull/2030#discussion_r885404211
##########
plugins/helper/batch_save.go:
##########
@@ -106,47 +106,40 @@ func isPrimaryKey(f reflect.StructField) bool {
return strings.HasPrefix(strings.ToLower(tag), "primarykey")
}
-func hasPrimaryKey(ifv reflect.Type) bool {
+func hasPrimaryKey(ifv reflect.Type, needRecursion bool) bool {
Review Comment:
when do we need this flag? I think it should be always recursive except when `primaryKey` is found inside `gorm` tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #2030: add migration for directrun; update feishu model
Posted by GitBox <gi...@apache.org>.
klesh merged PR #2030:
URL: https://github.com/apache/incubator-devlake/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org