You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/05 06:04:11 UTC
[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #293: [FLINK-28348] Add configurable flag to disable last-state fallback for savepoint upgrade
morhidi opened a new pull request, #293:
URL: https://github.com/apache/flink-kubernetes-operator/pull/293
Introducing `kubernetes.operator.job.upgrade.last-state-fallback.enabled` variable to enable configurable fall-back to last-state upgrade when the job is not running but HA is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #293: [FLINK-28348] Add configurable flag to disable last-state fallback for savepoint upgrade
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #293:
URL: https://github.com/apache/flink-kubernetes-operator/pull/293#discussion_r913425841
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -230,4 +230,10 @@ public class KubernetesOperatorConfigOptions {
.defaultValue(10)
.withDescription(
"Max attempts of automatic reconcile retries on recoverable errors.");
+
+ public static final ConfigOption<Boolean> OPERATOR_JOB_UPGRADE_LAST_STATE_FALLBACK_ENABLED =
+ ConfigOptions.key("kubernetes.operator.job.upgrade.last-state-fallback.enabled")
+ .booleanType()
+ .defaultValue(true)
+ .withDescription("Enables last-state fallback for savepoint upgrade mode.");
Review Comment:
We should add a bit more detail here, when/why this would happen
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -281,6 +282,11 @@ public static boolean isKubernetesHAActivated(Configuration configuration) {
.equalsIgnoreCase(KubernetesHaServicesFactory.class.getCanonicalName());
}
+ public static boolean isLastStateFallbackEnabled(Configuration configuration) {
+ return configuration.getBoolean(
+ KubernetesOperatorConfigOptions.OPERATOR_JOB_UPGRADE_LAST_STATE_FALLBACK_ENABLED);
+ }
+
Review Comment:
Do we need a utility method for this? The config.get is pretty self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #293: [FLINK-28348] Add configurable flag to disable last-state fallback for savepoint upgrade
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #293:
URL: https://github.com/apache/flink-kubernetes-operator/pull/293#issuecomment-1174725973
@gyfora addressed your comments, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #293: [FLINK-28348] Add configurable flag to disable last-state fallback for savepoint upgrade
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #293:
URL: https://github.com/apache/flink-kubernetes-operator/pull/293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org