You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/07/02 10:58:41 UTC
[GitHub] [arrow-datafusion] alamb commented on issue #6784: The `dict_id` was lost when constructing the logic plan.
alamb commented on issue #6784:
URL: https://github.com/apache/arrow-datafusion/issues/6784#issuecomment-1616599606
I wonder if you can explain how you are using `dict_id` in Schema? That field in particular is quite old in the code, and @tustvold and I have discussed at various times removing it as it doesn't seem to be widely used / supported. However we couldn't convince ourselves that was a good idea -- mostly because we don't know what people are using it for
> By the way, if you think my draft implementation works, I'd be happy to continue implementing it and contributing to the community.
Thank you for your efforts so far -- I did look (briefly) at the code and while it follows the existing patterns for metadata / nullable it felt to me like it was going to be hard to ensure all cases were covered properly (aka it was going to be hard to use)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org