[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2892: ARTEMIS-2549 - Add Downstream support to Federation

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2892: ARTEMIS-2549 - Add Downstream support to Federation
URL: https://github.com/apache/activemq-artemis/pull/2892#discussion_r348462517
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/address/FederatedAddress.java
 ##########
 @@ -113,7 +116,31 @@ public void start() {
     */
    @Override
    public synchronized void afterCreateQueue(Queue queue) {
-      createRemoteConsumer(queue);
+      conditionalCreateRemoteConsumer(queue);
+   }
+
+   private void conditionalCreateRemoteConsumer(Queue queue) {
+      //Always create demand if not a federated queue
+      if (!queue.getName().toString().startsWith(FEDERATED_QUEUE_PREFIX)) {
 
 Review comment:
   On federated address through it wasn't meant to be demand based on consumer, it was purely meant to be demand based on if there is a queue, e.g. multicast dispatch over the joined brokers. e.g. producers producers to "foo" on brokerA if brokerB had a queue under the address then a remote queue would be created on brokerA and the message would dispatch to brokerB, regardless if that queue had subscriber or not, e.g. handles cases of durable subscriptions, what was nice, is JMS non durable subs, as soon as consumer goes anyhow queue would go, and thus demand goes, as such demand just needed to be down to if queue or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services