You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2018/05/23 15:45:00 UTC
[jira] [Comment Edited] (POOL-338) GenericObjectPool constructor
throws an exception
[ https://issues.apache.org/jira/browse/POOL-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487500#comment-16487500 ]
Gary Gregory edited comment on POOL-338 at 5/23/18 3:44 PM:
------------------------------------------------------------
I'm finally coming back around to this. I am updating the patch attached to this ticket to account for the patch in your previous comment as well as some other minor clean ups.
May you please test again and report here?
WRT to your question (1): The reference is [https://docs.oracle.com/javase/specs/jls/se8/html/jls-12.html#jls-12.4.2] (no time to dig in)
WRT to your question (2): We could just remove {{BaseGenericObjectPool.setEvictionPolicyClass()}} as a YAGNI.
was (Author: garydgregory):
I'm finally coming back around to this. I am updating the patch attached to this ticket to account for the patch in your previous comment as well as some other minor clean ups.
May you please test again and report here?
WRT to your question (1): The reference is [https://docs.oracle.com/javase/specs/jls/se8/html/jls-12.html#jls-12.4.2]
WRT to your question (2): We could just remove {{BaseGenericObjectPool.setEvictionPolicyClass()}} as a YAGNI.
> GenericObjectPool constructor throws an exception
> -------------------------------------------------
>
> Key: POOL-338
> URL: https://issues.apache.org/jira/browse/POOL-338
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 2.4.2, 2.4.3, 2.5.0
> Environment: Java 8, Liferay DXP (an OSGi environment).
> Reporter: Michael C
> Priority: Major
> Attachments: commons-pool-gg.patch
>
>
> Version 2.4.3 GenericObjectPool constructor throws this exception:
> {{java.lang.IllegalArgumentException: [org.apache.commons.pool2.impl.DefaultEvictionPolicy] does not implement EvictionPolicy}}
> {{ at org.apache.commons.pool2.impl.BaseGenericObjectPool.setEvictionPolicyClassName(BaseGenericObjectPool.java:618)}}
> {{ at org.apache.commons.pool2.impl.GenericObjectPool.setConfig(GenericObjectPool.java:318)}}
> {{ at org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:115)}}
> {{ at org.apache.commons.pool2.impl.GenericObjectPool.<init>(GenericObjectPool.java:88)}}
>
> Version 2.5.0 throws the same exception. Version 2.4.2 or older's setEvictionPolicyClassName method fail silently for the same reason. This line in BaseGenericObjectPool evaluates to false for all versions:
> {{ if (policy instanceof EvictionPolicy<?>) {}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)