You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Rakesh Sharma <ra...@expedia.com> on 2015/06/30 11:52:18 UTC
Review Request 36042: Review Request for custom tool options for user
defined plugins for sqoop(SQOOP-2333)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
Review request for Sqoop and Venkat Ranganathan.
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/#review94614
-----------------------------------------------------------
Ship it!
Thanks for updating the patch. Will commit it after running unit tests
- Venkat Ranganathan
On Aug. 6, 2015, 12:33 a.m., Rakesh Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36042/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2015, 12:33 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Bugs: SQOOP-2333
> https://issues.apache.org/jira/browse/SQOOP-2333
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
>
>
> Diffs
> -----
>
> src/docs/dev/SqoopDevGuide.txt a81cfda
> src/docs/dev/plugin-arch.txt PRE-CREATION
> src/java/org/apache/sqoop/SqoopOptions.java 9405605
> src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
> src/test/org/apache/sqoop/util/TestSqoopJsonUtil.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36042/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Rakesh Sharma
>
>
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 7:33 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Updated the test case name
Bugs: SQOOP-2333
https://issues.apache.org/jira/browse/SQOOP-2333
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs (updated)
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
src/test/org/apache/sqoop/util/TestSqoopJsonUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/#review93948
-----------------------------------------------------------
Looks good. One more change. The SqoopJsonUtilTest has no special dependency and ideally should be run as part of ant test. Please change the name of the class to start with Test so that is automatically run as part of ant test.
- Venkat Ranganathan
On July 29, 2015, 11:09 p.m., Rakesh Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36042/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 11:09 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Bugs: SQOOP-2333
> https://issues.apache.org/jira/browse/SQOOP-2333
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
>
>
> Diffs
> -----
>
> src/docs/dev/SqoopDevGuide.txt a81cfda
> src/docs/dev/plugin-arch.txt PRE-CREATION
> src/java/org/apache/sqoop/SqoopOptions.java 9405605
> src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
> src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36042/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Rakesh Sharma
>
>
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
(Updated July 30, 2015, 6:09 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Bugs: SQOOP-2333
https://issues.apache.org/jira/browse/SQOOP-2333
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs (updated)
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/#review93547
-----------------------------------------------------------
Please fix the trailing spaces - looks good otherwise
src/docs/dev/plugin-arch.txt (line 53)
<https://reviews.apache.org/r/36042/#comment147928>
Minor nit - trailing spaces
- Venkat Ranganathan
On July 29, 2015, 12:30 a.m., Rakesh Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36042/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 12:30 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Bugs: SQOOP-2333
> https://issues.apache.org/jira/browse/SQOOP-2333
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
>
>
> Diffs
> -----
>
> src/docs/dev/SqoopDevGuide.txt a81cfda
> src/docs/dev/plugin-arch.txt PRE-CREATION
> src/java/org/apache/sqoop/SqoopOptions.java 9405605
> src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
> src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36042/diff/
>
>
> Testing
> -------
>
> YES
>
>
> Thanks,
>
> Rakesh Sharma
>
>
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
(Updated July 29, 2015, 7:30 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Updated documentation to get rid of extra trailing spaces
Bugs: SQOOP-2333
https://issues.apache.org/jira/browse/SQOOP-2333
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs (updated)
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
(Updated July 29, 2015, 7:25 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Get rid of extra spaces
Bugs: SQOOP-2333
https://issues.apache.org/jira/browse/SQOOP-2333
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs (updated)
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
(Updated July 29, 2015, 7:20 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Added unit test cases and also updated the documentation
Bugs: SQOOP-2333
https://issues.apache.org/jira/browse/SQOOP-2333
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs (updated)
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma
Re: Review Request 36042: Review Request for custom tool options for
user defined plugins for sqoop(SQOOP-2333)
Posted by Rakesh Sharma <ra...@expedia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36042/
-----------------------------------------------------------
(Updated July 6, 2015, 3:44 p.m.)
Review request for Sqoop and Venkat Ranganathan.
Bugs: SQOOP-2333
https://issues.apache.org/jira/browse/SQOOP-2333
Repository: sqoop-trunk
Description
-------
Sqoop allows users to develop their own plugins. But currently there is no way user plugins can have their custom options. Users will have to use sqoop predefined options. This patch adds support for a map to SqoopOptions which opens up possibilities for users to add their custom options as key/value pairs in the map.
Diffs
-----
src/docs/dev/SqoopDevGuide.txt a81cfda
src/docs/dev/plugin-arch.txt PRE-CREATION
src/java/org/apache/sqoop/SqoopOptions.java 9405605
src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION
Diff: https://reviews.apache.org/r/36042/diff/
Testing
-------
YES
Thanks,
Rakesh Sharma