You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2015/05/11 20:21:05 UTC
svn commit: r1678789 - in /commons/proper/imaging/trunk/src: main/java/org/apache/commons/imaging/formats/tiff/constants/ main/java/org/apache/commons/imaging/formats/tiff/write/ test/java/org/apache/commons/imaging/formats/tiff/write/

Author: britter
Date: Mon May 11 18:21:04 2015
New Revision: 1678789

URL: http://svn.apache.org/r1678789
Log:
Fix FindBugs warning: Field is a mutable array (MS_MUTABLE_ARRAY)

Modified:
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/constants/GpsTagConstants.java
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java
    commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSetTest.java

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/constants/GpsTagConstants.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/constants/GpsTagConstants.java?rev=1678789&r1=1678788&r2=1678789&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/constants/GpsTagConstants.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/constants/GpsTagConstants.java Mon May 11 18:21:04 2015
@@ -33,7 +33,11 @@ public final class GpsTagConstants {
             "GPSVersionID", 0x0000, 4,
             TiffDirectoryType.EXIF_DIRECTORY_GPS);
 
-    public static final byte[] GPS_VERSION = new byte[] { (byte)2, (byte)3, (byte)0, (byte)0 };
+    private static final byte[] GPS_VERSION = new byte[] { (byte)2, (byte)3, (byte)0, (byte)0 };
+    
+    public static byte[] gpsVersion() {
+        return GPS_VERSION.clone();
+    }
     
     // ************************************************************
     public static final TagInfoAscii GPS_TAG_GPS_LATITUDE_REF = new TagInfoAscii(

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java?rev=1678789&r1=1678788&r2=1678789&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java Mon May 11 18:21:04 2015
@@ -139,7 +139,7 @@ public final class TiffOutputSet {
         final TiffOutputDirectory gpsDirectory = getOrCreateGPSDirectory();
 
         gpsDirectory.removeField(GpsTagConstants.GPS_TAG_GPS_VERSION_ID);
-        gpsDirectory.add(GpsTagConstants.GPS_TAG_GPS_VERSION_ID, GpsTagConstants.GPS_VERSION);
+        gpsDirectory.add(GpsTagConstants.GPS_TAG_GPS_VERSION_ID, GpsTagConstants.gpsVersion());
 
         final String longitudeRef = longitude < 0 ? "W" : "E";
         longitude = Math.abs(longitude);

Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSetTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSetTest.java?rev=1678789&r1=1678788&r2=1678789&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSetTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSetTest.java Mon May 11 18:21:04 2015
@@ -44,7 +44,7 @@ public class TiffOutputSetTest {
         TiffOutputField gpsVersionId = tiffOutputSet.findField(GpsTagConstants.GPS_TAG_GPS_VERSION_ID);
 
         assertNotNull(gpsVersionId);
-        assertTrue(gpsVersionId.bytesEqual(GpsTagConstants.GPS_VERSION));
+        assertTrue(gpsVersionId.bytesEqual(GpsTagConstants.gpsVersion()));
     }
 
 }