You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jo...@apache.org on 2016/07/13 20:24:30 UTC
[3/7] mesos git commit: Fixed memory leaks in Encoder/Decoder tests
in libprocess.
Fixed memory leaks in Encoder/Decoder tests in libprocess.
Review: https://reviews.apache.org/r/46094/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ca245549
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/ca245549
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/ca245549
Branch: refs/heads/master
Commit: ca2455499c5647309b4e135d1f96f1523e4188fb
Parents: 0a4b284
Author: Neil Conway <ne...@gmail.com>
Authored: Wed Jul 13 11:37:29 2016 -0700
Committer: Joseph Wu <jo...@apache.org>
Committed: Wed Jul 13 13:21:07 2016 -0700
----------------------------------------------------------------------
3rdparty/libprocess/src/tests/decoder_tests.cpp | 6 ++++--
3rdparty/libprocess/src/tests/encoder_tests.cpp | 4 +++-
2 files changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/ca245549/3rdparty/libprocess/src/tests/decoder_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/tests/decoder_tests.cpp b/3rdparty/libprocess/src/tests/decoder_tests.cpp
index bd990c5..62e29c9 100644
--- a/3rdparty/libprocess/src/tests/decoder_tests.cpp
+++ b/3rdparty/libprocess/src/tests/decoder_tests.cpp
@@ -15,6 +15,7 @@
#include <deque>
#include <string>
+#include <process/owned.hpp>
#include <process/socket.hpp>
#include <stout/gtest.hpp>
@@ -25,6 +26,7 @@ namespace http = process::http;
using process::DataDecoder;
using process::Future;
+using process::Owned;
using process::ResponseDecoder;
using process::StreamingResponseDecoder;
@@ -170,7 +172,7 @@ TEST(DecoderTest, StreamingResponse)
EXPECT_TRUE(decoder.writingBody());
ASSERT_EQ(1, responses.size());
- http::Response* response = responses[0];
+ Owned<http::Response> response(responses[0]);
EXPECT_EQ("200 OK", response->status);
EXPECT_EQ(3, response->headers.size());
@@ -222,7 +224,7 @@ TEST(DecoderTest, StreamingResponseFailure)
EXPECT_TRUE(decoder.writingBody());
ASSERT_EQ(1, responses.size());
- http::Response* response = responses[0];
+ Owned<http::Response> response(responses[0]);
EXPECT_EQ("200 OK", response->status);
EXPECT_EQ(3, response->headers.size());
http://git-wip-us.apache.org/repos/asf/mesos/blob/ca245549/3rdparty/libprocess/src/tests/encoder_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/tests/encoder_tests.cpp b/3rdparty/libprocess/src/tests/encoder_tests.cpp
index 9153dda..9e57375 100644
--- a/3rdparty/libprocess/src/tests/encoder_tests.cpp
+++ b/3rdparty/libprocess/src/tests/encoder_tests.cpp
@@ -17,6 +17,7 @@
#include <vector>
#include <process/http.hpp>
+#include <process/owned.hpp>
#include <process/socket.hpp>
#include <stout/gtest.hpp>
@@ -27,6 +28,7 @@
namespace http = process::http;
using process::HttpResponseEncoder;
+using process::Owned;
using process::ResponseDecoder;
using std::deque;
@@ -50,7 +52,7 @@ TEST(EncoderTest, Response)
ASSERT_FALSE(decoder.failed());
ASSERT_EQ(1, responses.size());
- http::Response* decoded = responses[0];
+ Owned<http::Response> decoded(responses[0]);
EXPECT_EQ("200 OK", decoded->status);
EXPECT_EQ("body", decoded->body);