You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/11 12:53:43 UTC

[GitHub] [flink] maxCodeVector commented on a change in pull request #18854: [FLINK-25648][Kubernetes] Avoid redundant to query Kubernetes deployment when creating task manager pods

maxCodeVector commented on a change in pull request #18854:
URL: https://github.com/apache/flink/pull/18854#discussion_r824687133



##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -130,15 +132,16 @@ public void createJobManagerComponent(KubernetesJobManagerSpecification kubernet
 
     @Override
     public CompletableFuture<Void> createTaskManagerPod(KubernetesPod kubernetesPod) {
+        if (masterDeployment == null) {

Review comment:
       Yeah, I agree. It may have some thread-safe problem. I will update this part.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org