You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Benedikt Ritter (JIRA)" <ji...@apache.org> on 2015/02/02 14:55:35 UTC
[jira] [Updated] (IMAGING-159) There should be a Parameters class
[ https://issues.apache.org/jira/browse/IMAGING-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benedikt Ritter updated IMAGING-159:
------------------------------------
Fix Version/s: (was: Patch Needed)
Review Patch
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Reporter: Benedikt Ritter
> Fix For: Review Patch
>
>
> Currently options for image I/O are defined as Maps. The leads to the problem that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides additional methods like {{public int getInt(String key)}}. The implementation could then look up the value from the map through an exception if it is null or not a number.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)