You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thorsten Schöning (Jira)" <ji...@apache.org> on 2020/03/20 08:07:00 UTC
[jira] [Updated] (WICKET-6756) Avoid URL.getFile() when actually
expecting paths.
[ https://issues.apache.org/jira/browse/WICKET-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Schöning updated WICKET-6756:
--------------------------------------
Description:
[WICKET-6714|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6714] introduced using "URL.getFile" to convert some parts of an URL to a path in the local file system. This doesn't work properly, because the result of "getFile" is not properly decoded e.g. in case the URL/path contains spaces. While this concrete issue has been fixed by [WICKET-6755|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6755] already, in theory this needs to be fixed i the entire code base as well. Each place URL.getFile is used to get some local file system path is wrong.
https://stackoverflow.com/questions/2166039/java-how-to-get-a-file-from-an-escaped-url
This is issue is created to make aware of that problem and because during WICKET-6755 I've found at least one additional place already where this problem happens.
was:
[WICKET-6714|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6714] introduced using "URL.getFile" to convert some parts of an URL to a path in the local file system. This doesn't work properly, because the result of "getFile" is not properly decoded e.g. in case the URL/path contains spaces. While this concrete issue has been fixed by [WICKET-6714|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6755] already, in theory this needs to be fixed i the entire code base as well. Each place URL.getFile is used to get some local file system path is wrong.
https://stackoverflow.com/questions/2166039/java-how-to-get-a-file-from-an-escaped-url
This is issue is created to make aware of that problem and because during WICKET-6755 I've found at least one additional place already where this problem happens.
> Avoid URL.getFile() when actually expecting paths.
> --------------------------------------------------
>
> Key: WICKET-6756
> URL: https://issues.apache.org/jira/browse/WICKET-6756
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 8.7.0
> Reporter: Thorsten Schöning
> Assignee: Sven Meier
> Priority: Major
> Fix For: 9.0.0-M5, 8.8.0
>
>
> [WICKET-6714|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6714] introduced using "URL.getFile" to convert some parts of an URL to a path in the local file system. This doesn't work properly, because the result of "getFile" is not properly decoded e.g. in case the URL/path contains spaces. While this concrete issue has been fixed by [WICKET-6755|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6755] already, in theory this needs to be fixed i the entire code base as well. Each place URL.getFile is used to get some local file system path is wrong.
> https://stackoverflow.com/questions/2166039/java-how-to-get-a-file-from-an-escaped-url
> This is issue is created to make aware of that problem and because during WICKET-6755 I've found at least one additional place already where this problem happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)