You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/09 05:18:54 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #7773:
Improve examples & related tests
mistercrunch opened a new pull request #7773: Improve examples & related tests
URL: https://github.com/apache/incubator-superset/pull/7773
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
related to #7478
This enables setting up an alternative URI for loading/storing/serving the examples data. New URI is defined with config key `SQLALCHEMY_EXAMPLES_URI`. If nothing not set explicitly, will default to point to the metadata database (`SQLALCHEMY_DATABASE_URI`). This in turn adds a new default entry to the `Database` model named `examples`
As a result, examples data tables can now be reused across Superset environments, and the tables don't get mixed in with the metadata database, leaving it cleaner.
### Approach
* allowing specifying an alternate database connection for examples
* allowing a --only-metadata flag to `load_examples` to load only
dashboard and chart definitions, no actual data is loaded
* fixed a bunch of tests that are in some cases not directly related to this, but were not idempotent and prevented me from making progress.
Longer term we will generate the examples by exporting
them into tarball as in #7472.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org