You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/06/17 11:07:19 UTC
[PR] [fix][test] Fix TableViewBuilderImplTest NPE and infinite loop [pulsar]
lhotari opened a new pull request, #22924:
URL: https://github.com/apache/pulsar/pull/22924
### Motivation
Running the test TableViewBuilderImplTest results in an NPE and infinite loop.
### Modifications
Properly mock readNextAsync by returning an uncompleted CompletableFuture so that it doesn't cause an infinite loop.
Complete the CompletableFuture with AlreadyClosedException in test cleanup to properly close resources.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix TableViewBuilderImplTest NPE and infinite loop [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22924:
URL: https://github.com/apache/pulsar/pull/22924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org