You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2012/11/06 02:47:56 UTC
Review Request: Parameterize tag currently hardcoded
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7886/
-----------------------------------------------------------
Review request for oozie.
Description
-------
currently <uris> is hardcoded. Use static variable for it.
https://issues.apache.org/jira/browse/OOZIE-1044
This addresses bug OOZIE-1044.
https://issues.apache.org/jira/browse/OOZIE-1044
Diffs
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1404717
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1404717
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1404717
branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 1404717
branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1404717
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1404717
Diff: https://reviews.apache.org/r/7886/diff/
Testing
-------
local test done
Thanks,
Ryota Egashira
Re: Review Request: Parameterize tag currently hardcoded
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7886/
-----------------------------------------------------------
(Updated Nov. 9, 2012, 8:20 a.m.)
Review request for oozie.
Changes
-------
rebased patch uploaded.
Description
-------
currently <uris> is hardcoded. Use static variable for it.
https://issues.apache.org/jira/browse/OOZIE-1044
This addresses bug OOZIE-1044.
https://issues.apache.org/jira/browse/OOZIE-1044
Diffs (updated)
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1407371
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1407371
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1407371
branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 1407371
branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1407371
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1407371
Diff: https://reviews.apache.org/r/7886/diff/
Testing
-------
local test done
Thanks,
Ryota Egashira
Re: Review Request: Parameterize tag currently hardcoded
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7886/#review13255
-----------------------------------------------------------
Ship it!
Looks fine. Patch doesnt apply to branch head. Please rebase after updating repo and also upload to JIRA.
- Mona Chitnis
On Nov. 6, 2012, 1:47 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7886/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 1:47 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> currently <uris> is hardcoded. Use static variable for it.
> https://issues.apache.org/jira/browse/OOZIE-1044
>
>
> This addresses bug OOZIE-1044.
> https://issues.apache.org/jira/browse/OOZIE-1044
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1404717
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1404717
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1404717
> branches/hcat-intre/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java 1404717
> branches/hcat-intre/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1404717
> branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1404717
>
> Diff: https://reviews.apache.org/r/7886/diff/
>
>
> Testing
> -------
>
> local test done
>
>
> Thanks,
>
> Ryota Egashira
>
>