You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 23:01:50 UTC
[GitHub] [airflow] kaxil opened a new pull request #13236: Add Guidelines to become an Airflow Committer
kaxil opened a new pull request #13236:
URL: https://github.com/apache/airflow/pull/13236
Same as discussed and agreed on Devlist
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#issuecomment-749282375
I wonder if we should move these guidelines a little further down in this document. I would like the beginning of this document to find useful information for new contributors. This information is not interesting for most people, which will discourage reading this document.
Looking at the table of contents, it seems to me that chapters "Becoming a Committer", "Guidelines for promoting Committers to Airflow PMC", "Inactive Committers", "Guidelines to become an Airflow Committer" should be placed elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547433193
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed a holistic understanding of a particular part and made contributions towards a more
+ strategic goal
+5. Has made a significant improvement or added an integration with services/technologies important to the Airflow
+ Ecosystem
+
+Community contributions
+^^^^^^^^^^^^^^^^^^^^^^^^
+
+1. Was instrumental in triaging issues.
Review comment:
```suggestion
1. Was instrumental in triaging issues
```
To be consistent with other lines.
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed a holistic understanding of a particular part and made contributions towards a more
+ strategic goal
+5. Has made a significant improvement or added an integration with services/technologies important to the Airflow
+ Ecosystem
+
+Community contributions
+^^^^^^^^^^^^^^^^^^^^^^^^
+
+1. Was instrumental in triaging issues.
+2. Improved documentation of Airflow in significant way
+3. Lead change and improvements introduction in the “community” processes and tools
+4. Actively spreads the word about Airflow, example organising Airflow summit, workshops for
Review comment:
```suggestion
4. Actively spreads the word about Airflow, for example organising Airflow summit, workshops for
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547009836
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high quality commits (especially commit messages), and assess the impact of the changes including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed holistic understanding of a particular part and made contributions towards a more
+ strategic goal
+5. Has made significant improvement or added an integration with services/technologies important to the Airflow
Review comment:
```suggestion
5. Has made a significant improvement or added an integration with services/technologies important to the Airflow
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547014377
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high quality commits (especially commit messages), and assess the impact of the changes including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed holistic understanding of a particular part and made contributions towards a more
+ strategic goal
+5. Has made significant improvement or added an integration with services/technologies important to the Airflow
+ Ecosystem
+
+Community contributions
+^^^^^^^^^^^^^^^^^^^^^^^^
+
+1. Was instrumental in triaging issues.
+2. Improved documentation of Airflow in significant way
+3. Lead change and improvements introduction in the “community” processes and tools
+4. Actively spreads the word about Airflow, example organising Airflow summit, workshops for
+ community members, giving and recording talks, writing blogs
+5. Reporting bugs with details reproduction steps
Review comment:
```suggestion
5. Reporting bugs with detailed reproduction steps
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551468110
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
Review comment:
I guess we might link to it.
This is rather different level but they describe what "active" committer should be responsible for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547014145
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
Review comment:
Is is related to "Committer Responsibilities" section?
https://github.com/apache/airflow/blob/6f78c4b909de875809825f18c1873e724bd20ce6/CONTRIBUTING.rst#committer-responsibilities
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547008421
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
Review comment:
```suggestion
As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551145837
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
Review comment:
```suggestion
3. Proposed and led to completion of Airflow Improvement Proposal(s)
```
But I'm not a native speaker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#issuecomment-756976247
🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13236:
URL: https://github.com/apache/airflow/pull/13236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551439541
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
Review comment:
:D indeed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547008707
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high quality commits (especially commit messages), and assess the impact of the changes including
Review comment:
```suggestion
1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#issuecomment-756976247
🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551443963
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
Review comment:
Updated in e729fc1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547009104
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high quality commits (especially commit messages), and assess the impact of the changes including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed holistic understanding of a particular part and made contributions towards a more
Review comment:
```suggestion
Providers or has displayed a holistic understanding of a particular part and made contributions towards a more
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551443810
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed a holistic understanding of a particular part and made contributions towards a more
Review comment:
Updated in https://github.com/apache/airflow/pull/13236/commits/e729fc1bc86cf3f5369e41f1162c95ab1eb6ee07
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547008198
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
Review comment:
```suggestion
Committers are community members who have write access to the project’s
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547409778
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
Review comment:
:heart:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547008610
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
Review comment:
```suggestion
3. Helped to improve a community of Airflow to be stronger
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#issuecomment-751241210
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547007107
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
Review comment:
```suggestion
(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r547008707
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance due to a change of job or circumstances) you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members that have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high quality commits (especially commit messages), and assess the impact of the changes including
Review comment:
```suggestion
1. Makes high-quality commits (especially commit messages), and assess the impact of the changes including
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551146216
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
+4. Demonstrates an understanding of Airflow Core, API, Docker image, Helm chart, dev tools or certain
+ Providers or has displayed a holistic understanding of a particular part and made contributions towards a more
Review comment:
As we are enumerating the areas, maybe it would be feasible to put them in bullet list for better readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551444093
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
+3. Helped to improve community of Airflow to be stronger
+4. Understands contributor/committer guidelines : Contributors' Guide
+
+
+Code contribution
+^^^^^^^^^^^^^^^^^^
+
+1. Makes high-quality commits (especially commit messages), and assess the impact of the changes, including
+ upgrade paths or deprecation policies
+2. Testing Release Candidates to help the release cycle
+3. Proposed and led to completion Airflow Improvement Proposal(s)
Review comment:
I think this one is fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13236:
URL: https://github.com/apache/airflow/pull/13236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551439541
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
Review comment:
😄 indeed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#issuecomment-751293209
Marked it as "Ready for review" @kaxil ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] aijamalnk commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
aijamalnk commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r553691032
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,77 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list, Slack channels or Github issues/discussions
+3. Helped to improve community of Airflow to be stronger
Review comment:
Maybe we can rephrase this a bit?
```suggestion
3. Contributions to community health and project's sustainability for the long-term
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#issuecomment-749282375
I wonder if we should move these guidelines a little further down in this document. I would like the beginning of this document to find useful information for new contributors. This information is boring for most people, which will discourage reading this document.
Looking at the table of contents, it seems to me that chapters "Becoming a Committer", "Guidelines for promoting Committers to Airflow PMC", "Inactive Committers", "Guidelines to become an Airflow Committer" should be placed elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13236: Add Guidelines to become an Airflow Committer
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13236:
URL: https://github.com/apache/airflow/pull/13236#discussion_r551145569
##########
File path: CONTRIBUTING.rst
##########
@@ -200,6 +200,69 @@ can become the Mentor and guide the proposed candidates on how they can become a
the mentor must try to remain impartial and cannot be the Proposer.
+Inactive Committers
+-------------------
+If you know you are not going to be able to contribute for a long time
+(for instance, due to a change of job or circumstances), you should inform the PMC and we will mark you
+as "inactive". Inactive committers will be removed from the "roster" on ASF and will no longer have the power
+of being a Committer (especially write access to the repos). As merit earned never expires, once you
+become active again you can simply email the PMC and ask to be reinstated.
+
+The PMC also can mark committers as inactive after they have not been involved in the community for
+more than 12 months.
+
+
+Guidelines to become an Airflow Committer
+------------------------------------------
+
+Committers are community members who have write access to the project’s
+repositories, i.e., they can modify the code, documentation, and website by themselves and also
+accept other contributions. There is no strict protocol for becoming a committer. Candidates for new
+committers are typically people that are active contributors and community members.
+
+Some people might be active in several of those areas and while they might have not enough 'achievements' in any
+single one of those, their combined contributions in several areas all count.
+
+As a community, we appreciate contributions to the Airflow codebase, but we also place equal value
+on those who help Airflow by improving the community in some way. It is entirely possible to become
+a committer (and eventually a PMC member) without ever having to change a single line of code.
+
+
+Prerequisites
+^^^^^^^^^^^^^^
+
+General prerequisites that we look for in all candidates:
+
+1. Consistent contribution over last few months
+2. Visibility on discussions on the dev mailing list and/or the Slack channel
Review comment:
Just for complement sake, should we add something like:
```suggestion
2. Visibility on discussions on the dev mailing list, Slack channels or Github issues/discussions
```
Btw `and/or == or` 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org