You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/25 07:29:24 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #2438: HBASE-25033 : Provide an option to ignore svn ci for create-release

virajjasani commented on a change in pull request #2438:
URL: https://github.com/apache/hbase/pull/2438#discussion_r494799780



##########
File path: dev-support/create-release/release-util.sh
##########
@@ -304,6 +306,10 @@ function check_needed_vars {
   return 0
 }
 
+function is_svn_ci_disabled {
+  [[ "$DRY_RUN" = 1 ]] || [[ "$IGNORE_SVN_CI" = 1 ]]

Review comment:
       > is this change for using -ignore-svn-ci with -f together?
   
   That's true, `ignore-svn-ci` is only useful when used in combination with `-f`, otherwise it is sort of no-op because dry-mode anyways don't perform svn ci.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org