You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by amilor <gi...@git.apache.org> on 2016/03/07 13:59:26 UTC
[GitHub] wicket pull request: Wicket forms - CompoundPropertyModel - sample...
GitHub user amilor opened a pull request:
https://github.com/apache/wicket/pull/162
Wicket forms - CompoundPropertyModel - sample java code issues
The java code example used two variables with identical name and of different type, not only this would not compile, but the used name could potentially steer wicket beginners in wrong direction of thinking (regarding the matter of topic in this code snippet).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amilor/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
----
commit c2b433572d291d01209e908a7440165067b618d0
Author: meno <am...@users.noreply.github.com>
Date: 2016-03-07T12:52:38Z
Update modelsforms_3.gdoc
Wicket forms - CompoundPropertyModel - traversed components ID not taken into account when creating expression for evaluation of model property
The java code example used two variables with identical name and of different type, not only this would not compile, but the used name could potentially steer wicket beginners in wrong direction of thinking (regarding the matter of topic in this code snippet).
commit c010e2d9643c467feff09071c3a5b721e40582be
Author: meno <am...@users.noreply.github.com>
Date: 2016-03-07T12:56:00Z
Merge pull request #1 from amilor/amilor-forms-cpm-sample-code-fix
Update modelsforms_3.gdoc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: User Guide - Wicket forms - CompoundPropertyM...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/162#issuecomment-193252769
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: User Guide - Wicket forms - CompoundPropertyM...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---