You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tao12345666333 (via GitHub)" <gi...@apache.org> on 2025/12/16 22:46:16 UTC

[PR] refactor(services/hdfs): split hdfs into separate crate [opendal]

tao12345666333 opened a new pull request, #7040:
URL: https://github.com/apache/opendal/pull/7040

   This PR splits the hdfs service into its own crate `opendal-service-hdfs`.
   
   - Create new crate at `core/services/hdfs`
   - Update feature flag to use the new crate
   - Remove hdfs from `opendal-core`
   - Re-export from facade crate
   
   Closes #6899
   
   ---
   
   I hereby agree to the terms of the Apache License, Version 2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(services/hdfs): split hdfs into separate crate [opendal]

Posted by "koushiro (via GitHub)" <gi...@apache.org>.
koushiro commented on code in PR #7040:
URL: https://github.com/apache/opendal/pull/7040#discussion_r2629454917


##########
core/services/hdfs/src/config.rs:
##########
@@ -85,8 +85,8 @@ impl crate::Configurator for HdfsConfig {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::Configurator;
-    use crate::types::OperatorUri;
+    use opendal_core::Configurator;
+    use opendal_core::types::OperatorUri;

Review Comment:
   ```suggestion
       use opendal_core::OperatorUri;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(services/hdfs): split hdfs into separate crate [opendal]

Posted by "koushiro (via GitHub)" <gi...@apache.org>.
koushiro commented on code in PR #7040:
URL: https://github.com/apache/opendal/pull/7040#discussion_r2629452646


##########
core/core/Cargo.toml:
##########
@@ -121,8 +120,21 @@ sha2 = { workspace = true, optional = true }
 # For http based services.
 reqsign = { workspace = true, default-features = false, optional = true }
 
-# for services-hdfs
-hdrs = { version = "0.3.2", optional = true, features = ["async_file"] }
+# for self-referencing structs
+# for services-cacache
+cacache = { version = "13.0", default-features = false, features = [
+  "tokio-runtime",
+  "mmap",
+], optional = true }
+# for services-etcd
+etcd-client = { version = "0.17", optional = true, features = ["tls"] }
+# for services-foundationdb
+foundationdb = { version = "0.9.0", features = [
+  "embedded-fdb-include",
+  "fdb-7_3",
+], optional = true }
+# for services-upyun
+hmac = { version = "0.12.1", optional = true }

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(services/hdfs): split hdfs into separate crate [opendal]

Posted by "koushiro (via GitHub)" <gi...@apache.org>.
koushiro merged PR #7040:
URL: https://github.com/apache/opendal/pull/7040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org