You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/16 12:54:00 UTC

[GitHub] [airflow] drcrook1 opened a new issue, #24493: Private Git Dag Links Force you to Kill Worker Pods

drcrook1 opened a new issue, #24493:
URL: https://github.com/apache/airflow/issues/24493

   ### Apache Airflow version
   
   2.3.2 (latest released)
   
   ### What happened
   
   Deployed a helm upgrade of: apache-airflow/airflow with added private git repo dags.  This worked, however, I had to have the kubernetes admin kill the worker pods because they entered a non recoverable failure state.  Once they were killed, they booted back up perfectly happy.
   
   This leads me to a suspicion that if the private git dag worker (excuse my lack of inner workings here of airflow) if it fails will cause the workers to go back into a failed state.
   
   This is something which is highly un-desireable.  I do very much like being able to link multiple private git repos so all teams who are building dags can have their dags link up.
   
   ### What you think should happen instead
   
   When adding a private repo, the workers should not enter a failed state.
   
   ### How to reproduce
   
   helm upgrade --install airflow apache-airflow/airflow --namespace airflow --create-namespace `
       -f override-values.yaml
   
   ovverride-values.yaml contents below:
   
   dags:
     gitSync:
       enabled: true
       repo: ssh://git@github.com/youruserid/yourrepo.git
       branch: main
       subPath: ""
       sshKeySecret: airflow-ssh-secret
   extraSecrets:
     airflow-ssh-secret:
       data: |
         gitSshKey: 'your key'
   
   ### Operating System
   
   windows 11
   
   ### Versions of Apache Airflow Providers
   
   default everything.
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   Deployed to Azure Kubernetes Service in East US.
   
   ### Anything else
   
   Happens so far every time.  I'm working on the automated deployments, and it seems pretty consistent every time I blow out the deployment and do it again.
   
   I suppose I could submit a PR.  I don't know much about this system but if somebody wants to buddy up with me, that would be pretty cool.  My day job would likely give me the bandwidth to do this.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] boring-cyborg[bot] commented on issue #24493: Private Git Dag Links Force you to Kill Worker Pods

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #24493:
URL: https://github.com/apache/airflow/issues/24493#issuecomment-1157626960

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk closed issue #24493: Private Git Dag Links Force you to Kill Worker Pods

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #24493: Private Git Dag Links Force you to Kill Worker Pods
URL: https://github.com/apache/airflow/issues/24493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org