You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by "rmannibucau (via GitHub)" <gi...@apache.org> on 2023/06/14 19:09:40 UTC

[GitHub] [karaf] rmannibucau opened a new pull request, #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

rmannibucau opened a new pull request, #1724:
URL: https://github.com/apache/karaf/pull/1724

   Mainly to show how to not have to update properties each 6 months (see #1723 for context)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] jbonofre commented on pull request #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1724:
URL: https://github.com/apache/karaf/pull/1724#issuecomment-1593223771

   @mattrpav we can't remove the old entries for some version of JDKs. However it's possible for Karaf 4.5.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] rmannibucau commented on pull request #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #1724:
URL: https://github.com/apache/karaf/pull/1724#issuecomment-1593209108

   @mattrpav the eecap and jre props defaulting to a previous value (or just appending their number) can be removed until java 9 (to keep). One option which is not bad is to decide to define all LTS and skip others, this enables to not loop too much but also to work most of the time without any explicit config so think it can be a wise compromise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] jbonofre merged pull request #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1724:
URL: https://github.com/apache/karaf/pull/1724


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] mattrpav commented on pull request #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on PR #1724:
URL: https://github.com/apache/karaf/pull/1724#issuecomment-1593200713

   @rmannibucau shouldn't the eecap-* entries the be able to be removed from the etc/config.properties? 
   
   This approach looks way better!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] jbonofre commented on pull request #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1724:
URL: https://github.com/apache/karaf/pull/1724#issuecomment-1593232699

   I'm testing/reviewing this PR. Thanks !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] jbonofre commented on pull request #1724: Ensure jre and eecap config.properties properties can be computed for modern jvms

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1724:
URL: https://github.com/apache/karaf/pull/1724#issuecomment-1592651342

   NB: the PR doesn't prevent the update in `etc/jre.properties` but help to deal with ee caps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org