You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Kimahriman (via GitHub)" <gi...@apache.org> on 2024/08/09 11:44:13 UTC

Re: [PR] fix: Improve support for nested structs [datafusion-comet]

Kimahriman commented on code in PR #800:
URL: https://github.com/apache/datafusion-comet/pull/800#discussion_r1711315646


##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -65,7 +65,8 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
         _: DateType | _: BooleanType | _: NullType =>
       true
     case dt if isTimestampNTZType(dt) => true
-    case s: StructType if allowStruct => s.fields.map(_.dataType).forall(supportedDataType(_))
+    case s: StructType if allowStruct =>
+      s.fields.map(_.dataType).forall(supportedDataType(_, allowStruct))

Review Comment:
   Good catch, I initially had `allowStruct` default to true which is why I didn't pass it on here, but missed this when I changed the default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org