You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2017/03/23 23:31:35 UTC

Review Request 57899: HDP 3.0 TP - create Service Advisor for Hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57899/
-----------------------------------------------------------

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-20552
    https://issues.apache.org/jira/browse/AMBARI-20552


Repository: ambari


Description
-------

Create a Service Advisor script for Hive in HDP 3.0 Tech Preview.
The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6
In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
However, batch and interactive will use different config files.
Tez is a dependency of Hive, so Tez must be able to install first.
In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
However, batch and interactive will use different config files.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/alerts.json PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/beeline-log4j2.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-atlas-application.properties.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-exec-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-exec-log4j2.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-log4j2.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-logsearch-conf.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hivemetastore-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hiveserver2-interactive-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hiveserver2-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/llap-cli-log4j2.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/llap-daemon-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-audit.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-plugin-properties.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-policymgr-ssl.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-security.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/tez-interactive-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-env.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-site.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/kerberos.json PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_interactive_thrift_port.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_metastore.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_thrift_port.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_llap_app_status.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_webhcat_server.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.mysql.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.oracle.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.postgres.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.mysql.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.oracle.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.postgres.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/upgrade-0.12.0-to-0.13.0.oracle.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/upgrade-0.13.0.oracle.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/addMysqlUser.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hcatSmoke.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveSmoke.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveTezSetup.cmd PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveserver2.sql PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveserver2Smoke.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/pigSmoke.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/removeMysqlUser.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/startMetastore.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/templetonSmoke.sh PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/__init__.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat_service_check.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_interactive.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_service.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_service_interactive.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_server.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_service.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_users.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_utils.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_windows.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive_interactive.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_server.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_service.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_service_check.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hive.conf.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/startHiveserver2.sh.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/zkmigrator_jaas.conf.j2 PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/quicklinks/quicklinks.json PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/themes/theme.json PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 61960bb 
  ambari-server/src/main/resources/stacks/HDP/3.0/services/HIVE/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/stack_advisor.py f874f6f 


Diff: https://reviews.apache.org/r/57899/diff/1/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 57899: HDP 3.0 TP - create Service Advisor for Hive

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57899/#review170033
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On March 24, 2017, 3:22 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57899/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 3:22 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-20552
>     https://issues.apache.org/jira/browse/AMBARI-20552
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a Service Advisor script for Hive in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6
> In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
> However, batch and interactive will use different config files.
> Tez is a dependency of Hive, so Tez must be able to install first.
> In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
> However, batch and interactive will use different config files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml a23f0bc 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 61960bb 
>   ambari-server/src/main/resources/stacks/stack_advisor.py f874f6f 
> 
> 
> Diff: https://reviews.apache.org/r/57899/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 57899: HDP 3.0 TP - create Service Advisor for Hive

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57899/
-----------------------------------------------------------

(Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 24, 2017, 3:22 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)


Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-20552
    https://issues.apache.org/jira/browse/AMBARI-20552


Repository: ambari


Description
-------

Create a Service Advisor script for Hive in HDP 3.0 Tech Preview.
The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6
In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
However, batch and interactive will use different config files.
Tez is a dependency of Hive, so Tez must be able to install first.
In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
However, batch and interactive will use different config files.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml a23f0bc 
  ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 61960bb 
  ambari-server/src/main/resources/stacks/stack_advisor.py f874f6f 


Diff: https://reviews.apache.org/r/57899/diff/2/

Changes: https://reviews.apache.org/r/57899/diff/1-2/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 57899: HDP 3.0 TP - create Service Advisor for Hive

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 23, 2017, 11:47 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Alejandro Fernandez wrote:
> > I think this is the wrong patch.

Nope, i just merged patches from two jiras "Merge Hive configs, widgets, metainfo and etc" and "Create service advisor". I will commit first one and then will attach only service advisor changes.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57899/#review169943
-----------------------------------------------------------


On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 23, 2017, 11:31 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57899/
> -----------------------------------------------------------
> 
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 23, 2017, 11:31 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-20552
>     https://issues.apache.org/jira/browse/AMBARI-20552
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a Service Advisor script for Hive in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6
> In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
> However, batch and interactive will use different config files.
> Tez is a dependency of Hive, so Tez must be able to install first.
> In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
> However, batch and interactive will use different config files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/alerts.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/beeline-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-atlas-application.properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-exec-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-exec-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-logsearch-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hivemetastore-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hiveserver2-interactive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hiveserver2-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/llap-cli-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/llap-daemon-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-audit.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-plugin-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-policymgr-ssl.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-security.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/tez-interactive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_interactive_thrift_port.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_metastore.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_thrift_port.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_llap_app_status.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_webhcat_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.mysql.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.postgres.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.mysql.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.postgres.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/upgrade-0.12.0-to-0.13.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/upgrade-0.13.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/addMysqlUser.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hcatSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveTezSetup.cmd PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveserver2.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveserver2Smoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/pigSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/removeMysqlUser.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/startMetastore.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/templetonSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat_service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_service_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_users.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hive.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/startHiveserver2.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/zkmigrator_jaas.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/quicklinks/quicklinks.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/themes/theme.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 61960bb 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/HIVE/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py f874f6f 
> 
> 
> Diff: https://reviews.apache.org/r/57899/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 57899: HDP 3.0 TP - create Service Advisor for Hive

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57899/#review169943
-----------------------------------------------------------



I think this is the wrong patch.

- Alejandro Fernandez


On March 23, 2017, 11:31 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57899/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 11:31 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-20552
>     https://issues.apache.org/jira/browse/AMBARI-20552
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a Service Advisor script for Hive in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6
> In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
> However, batch and interactive will use different config files.
> Tez is a dependency of Hive, so Tez must be able to install first.
> In HDP 3.0, Hive will use the same binary/RPM for both batch and interactive mode.
> However, batch and interactive will use different config files.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/alerts.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/beeline-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-atlas-application.properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-exec-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-exec-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-logsearch-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hivemetastore-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hiveserver2-interactive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hiveserver2-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/llap-cli-log4j2.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/llap-daemon-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-audit.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-plugin-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-policymgr-ssl.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/ranger-hive-security.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/tez-interactive-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/webhcat-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/kerberos.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_interactive_thrift_port.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_metastore.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_hive_thrift_port.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_llap_app_status.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/alerts/alert_webhcat_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.mysql.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.12.0.postgres.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.mysql.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/hive-schema-0.13.0.postgres.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/upgrade-0.12.0-to-0.13.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/etc/upgrade-0.13.0.oracle.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/addMysqlUser.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hcatSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveTezSetup.cmd PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveserver2.sql PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/hiveserver2Smoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/pigSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/removeMysqlUser.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/startMetastore.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/files/templetonSmoke.sh PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/__init__.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hcat_service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_metastore.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_server_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/hive_service_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_users.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/mysql_utils.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/setup_ranger_hive_interactive.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/webhcat_service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hivemetastore.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-hiveserver2.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llapdaemon.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hadoop-metrics2-llaptaskscheduler.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/hive.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/startHiveserver2.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/startHiveserver2Interactive.sh.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/templeton_smoke.pig.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/templates/zkmigrator_jaas.conf.j2 PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/quicklinks/quicklinks.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/themes/theme.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 61960bb 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/HIVE/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py f874f6f 
> 
> 
> Diff: https://reviews.apache.org/r/57899/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>