You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2023/05/24 09:06:57 UTC

[GitHub] [incubator-pekko] raboof opened a new pull request, #333: Document JAVA_8_HOME in error message

raboof opened a new pull request, #333:
URL: https://github.com/apache/incubator-pekko/pull/333

   When no Java 8 installation is found, mention in the error message that you can also use the JAVA_8_HOME environment variable to help the build find it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #333: Document JAVA_8_HOME in error message

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #333:
URL: https://github.com/apache/incubator-pekko/pull/333#discussion_r1203800989


##########
project/JdkOptions.scala:
##########
@@ -88,7 +88,7 @@ object JdkOptions extends AutoPlugin {
           jdk11options(java8home)
         case None =>
           throw new MessageOnlyException(
-            "A JDK 8 installation was not found, but is required to build Apache Pekko. To manually specify a JDK 8 installation, use the \"set every jdk8home := \\\"/path/to/jdk\\\" sbt command. If you have no JDK 8 installation, target your system JDK with the \"set every targetSystemJdk := true\" sbt command, but beware resulting artifacts will not work on JDK 8")
+            "A JDK 8 installation was not found, but is required to build Apache Pekko. To manually specify a JDK 8 installation, set the JAVA_8_HOME environment variable to its path or use the \"set every jdk8home := \\\"/path/to/jdk\\\" sbt command. If you have no JDK 8 installation, target your system JDK with the \"set every targetSystemJdk := true\" sbt command, but beware resulting artifacts will not work on JDK 8")

Review Comment:
   Yes, this is needed to build the doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] pjfanning commented on pull request #333: Document JAVA_8_HOME in error message

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #333:
URL: https://github.com/apache/incubator-pekko/pull/333#issuecomment-1560799332

   I think adding Windows style paths to the exception message may make the message more confusing. What we could aim to do is to work on a detailed installation guide and have the message link to that.
   
   That change could be done in a follow up PR when the detailed installation guide is ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin merged pull request #333: Document JAVA_8_HOME in error message

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #333:
URL: https://github.com/apache/incubator-pekko/pull/333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #333: Document JAVA_8_HOME in error message

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #333:
URL: https://github.com/apache/incubator-pekko/pull/333#discussion_r1203803609


##########
project/JdkOptions.scala:
##########
@@ -88,7 +88,7 @@ object JdkOptions extends AutoPlugin {
           jdk11options(java8home)
         case None =>
           throw new MessageOnlyException(
-            "A JDK 8 installation was not found, but is required to build Apache Pekko. To manually specify a JDK 8 installation, use the \"set every jdk8home := \\\"/path/to/jdk\\\" sbt command. If you have no JDK 8 installation, target your system JDK with the \"set every targetSystemJdk := true\" sbt command, but beware resulting artifacts will not work on JDK 8")
+            "A JDK 8 installation was not found, but is required to build Apache Pekko. To manually specify a JDK 8 installation, set the JAVA_8_HOME environment variable to its path or use the \"set every jdk8home := \\\"/path/to/jdk\\\" sbt command. If you have no JDK 8 installation, target your system JDK with the \"set every targetSystemJdk := true\" sbt command, but beware resulting artifacts will not work on JDK 8")

Review Comment:
   The syntax is not the same on `Windows`, and it will be `path\\to\\jdk`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org