You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2021/06/15 23:00:20 UTC

[superset] branch hiding-hidden-controls-for-real updated: fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch hiding-hidden-controls-for-real
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/hiding-hidden-controls-for-real by this push:
     new e52b5cf  fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption
e52b5cf is described below

commit e52b5cfd171671cb77bb5782f38ba40070f894cd
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Jun 15 16:57:47 2021 -0600

    fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption
---
 superset-frontend/src/explore/components/ControlRow.tsx | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/explore/components/ControlRow.tsx b/superset-frontend/src/explore/components/ControlRow.tsx
index d4ea063..4a1dfd5 100644
--- a/superset-frontend/src/explore/components/ControlRow.tsx
+++ b/superset-frontend/src/explore/components/ControlRow.tsx
@@ -30,9 +30,15 @@ export default function ControlRow({ controls }: { controls: Control[] }) {
   );
   const colSize = NUM_COLUMNS / countableControls.length;
   return (
-    <div className="row space-1">
+    <div className="row">
       {controls.map((control, i) => (
-        <div className={`col-lg-${colSize} col-xs-12`} key={i}>
+        <div
+          className={`col-lg-${colSize} col-xs-12`}
+          style={{
+            display: control?.props.type === 'HiddenControl' ? 'none' : 'block',
+          }}
+          key={i}
+        >
           {control}
         </div>
       ))}