[GitHub] [lucene] mocobeta edited a comment on pull request #207: LUCENE-9855: Rename nn search vector format

[GitBox <gi...@apache.org>]

mocobeta edited a comment on pull request #207:
URL: https://github.com/apache/lucene/pull/207#issuecomment-880628720


   > Maybe this one should not be renamed since it isn't related to nearest-neighbor search, it only allows iterating over vectors in doc ID order?
   
   `VectorValues` may be ok, but I think I don't fully understand your point yet. Besides iterating "vector"s, `VectorValues` has `SimilarityFunction` enum that is a clear indication of nearest neighbour search to me. If we will decouple the vector value class from any search algorithm, should we factor out the enum into somewhere?
   It seems you all agree with that we should keep the name `VectorValues` and I don't have strong opinion about it, but would you help me to make things clear before reverting the change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org