You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/04 10:17:42 UTC
[GitHub] [camel-kafka-connector] oscerd opened a new issue #186: Avoid Thread.sleep in test, use Awaitility FTW
oscerd opened a new issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
orpiske edited a comment on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-625117146
> The CamelSourceTaskTest in particular, wherever thread.sleep is used.
+1.
There's a few on CamelSourceAWSKinesisITCase too. Although they are using an approach similar to the one [suggest by amazon](https://docs.aws.amazon.com/general/latest/gr/api-retries.html), I still think they could be improved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] fvaleri edited a comment on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
fvaleri edited a comment on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-626303483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-625110852
> It's not really straighforward to do. We need probably to rethink the tests. I'll leave this open.
Is there any particular test you think it's problematic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
valdar commented on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-626389501
I preferred to get rid of sleep(...) as in #204. From a long run on my machine, they seem stable enough now.
@fvaleri @orpiske @oscerd feel free to improve it in any way you see fit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] fvaleri commented on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
fvaleri commented on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-626303483
There is a proposed refactoring of `CamelSourceTaskTest` here:
https://github.com/apache/camel-kafka-connector/pull/201
I'm not using Awaitility, but a shared method called `getTaskWithFixedNumberOfRecords`. All properties from `CamelSourceConnectorConfig` used inside it are tested in isolated methods, so I think it's fine to use them when testing source task behaviors that do not involve them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-625114677
The CamelSourceTaskTest in particular, wherever thread.sleep is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] oscerd commented on issue #186: Avoid Thread.sleep in test, use Awaitility FTW
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #186:
URL: https://github.com/apache/camel-kafka-connector/issues/186#issuecomment-625088281
It's not really straighforward to do. We need probably to rethink the tests. I'll leave this open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org