You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/08/23 06:49:22 UTC
svn commit: r1881091 - in /pdfbox/trunk/pdfbox/src/test:
java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
resources/org/apache/pdfbox/pdmodel/graphics/image/929316.png
Author: tilman
Date: Sun Aug 23 06:49:21 2020
New Revision: 1881091
URL: http://svn.apache.org/viewvc?rev=1881091&view=rev
Log:
PDFBOX-4847: improve test coverage to include the "store the specified rendering intent" and "we tag the image with the sRGB profile" cases with new file found on digitalcorpora.org
Added:
pdfbox/trunk/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/graphics/image/929316.png (with props)
Modified:
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java?rev=1881091&r1=1881090&r2=1881091&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java Sun Aug 23 06:49:21 2020
@@ -38,6 +38,7 @@ import org.apache.pdfbox.pdmodel.PDDocum
import org.apache.pdfbox.pdmodel.PDPage;
import org.apache.pdfbox.pdmodel.PDPageContentStream;
import org.apache.pdfbox.pdmodel.graphics.color.PDICCBased;
+import org.apache.pdfbox.pdmodel.graphics.color.PDIndexed;
import static org.apache.pdfbox.pdmodel.graphics.image.ValidateXImage.checkIdent;
import static org.junit.Assert.assertEquals;
@@ -339,4 +340,30 @@ public class PNGConverterTest
assertNull(PNGConverter.mapPNGRenderIntent(-1));
assertNull(PNGConverter.mapPNGRenderIntent(4));
}
+
+ /**
+ * Test code coverage for /Intent /Perceptual and for sRGB icc profile in indexed colorspace.
+ *
+ * @throws IOException
+ */
+ @Test
+ public void testImageConversionIntentIndexed() throws IOException
+ {
+ try (PDDocument doc = new PDDocument())
+ {
+ byte[] imageBytes = IOUtils.toByteArray(PNGConverterTest.class.getResourceAsStream("929316.png"));
+ PDImageXObject pdImageXObject = PNGConverter.convertPNGImage(doc, imageBytes);
+ assertEquals(COSName.PERCEPTUAL, pdImageXObject.getCOSObject().getItem(COSName.INTENT));
+
+ // Check that this image gets an indexed colorspace with sRGB ICC based colorspace
+ PDIndexed indexedColorspace = (PDIndexed) pdImageXObject.getColorSpace();
+
+ PDICCBased iccColorspace = (PDICCBased) indexedColorspace.getBaseColorSpace();
+ // validity of ICC CS is tested in checkImageConvert
+
+ assertTrue(iccColorspace.isIsRGB());
+ }
+
+ checkImageConvert("929316.png");
+ }
}
Added: pdfbox/trunk/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/graphics/image/929316.png
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/graphics/image/929316.png?rev=1881091&view=auto
==============================================================================
Binary file - no diff available.
Propchange: pdfbox/trunk/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/graphics/image/929316.png
------------------------------------------------------------------------------
svn:mime-type = image/png