[GitHub] [tinkerpop] vtslab commented on pull request #1308: TINKERPOP-2389 WIP: Authorization support in TinkerPop

[GitBox <gi...@apache.org>]

vtslab commented on pull request #1308:
URL: https://github.com/apache/tinkerpop/pull/1308#issuecomment-709849039


   Thanks @QwentB for further elaborating your thoughts. There are some aspects, though, that make me hesitant to pursue them.
   
   First, storing authorization data in the pipeline has some impact on the number of connections that can be open. That would be problematic in a scenario where many users are served who fire a query now and then. When the Authorizer caches the authorization data, however, it can simply put a limit on the size of the cache. 
   
   Secondly, while one could modify the RequestMessage to support specific usage scenarios, it does not seem necessary. If a RequestMessage is not admissable in its present form, the Authorizer can simply reject it and add a helpful reject message. Add/remove Strategies can be done by offering the same graph via different GraphTraversalSources that differ by the Strategies applied. So, I feel that the suggestion to have the Authorizer return a possibly modified RequestMessage is out of scope for the current PR. It could be added later on, if really required.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org