You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2004/03/14 18:05:02 UTC
[PATCH] Bug in libsvn_fs/db: fold_change
This is the bug which causes some cvs2svn-produced repositories to gain
spurious additional files when passed through a dump-load cycle.
[[[
* subversion/libsvn_fs/bdb/changes-table.c (fold_change):
The sequence "replace, delete" should fold to "delete", not "no-op".
]]]
[[[
Index: subversion/libsvn_fs/bdb/changes-table.c
===================================================================
--- subversion/libsvn_fs/bdb/changes-table.c (revision 9043)
+++ subversion/libsvn_fs/bdb/changes-table.c (working copy)
@@ -168,12 +168,10 @@
break;
case svn_fs_path_change_delete:
- if ((old_change->change_kind == svn_fs_path_change_replace)
- || (old_change->change_kind == svn_fs_path_change_add))
+ if (old_change->change_kind == svn_fs_path_change_add)
{
- /* If the path was introduced in this transaction via an
- add or replace, and we are deleting it, just remove
- the path altogether. */
+ /* If the path was introduced in this transaction via an add,
+ * and we are deleting it, just remove the path altogether.
*/
old_change = NULL;
}
else
]]]
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Bug in libsvn_fs/db: fold_change
Posted by "C. Michael Pilato" <cm...@collab.net>.
"Max Bowsher" <ma...@ukf.net> writes:
> This is the bug which causes some cvs2svn-produced repositories to gain
> spurious additional files when passed through a dump-load cycle.
>
> [[[
> * subversion/libsvn_fs/bdb/changes-table.c (fold_change):
> The sequence "replace, delete" should fold to "delete", not "no-op".
> ]]]
I'll just shepherd that into the code-base now thank-you-very-much...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org