You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by "Suat Gonul (JIRA)" <ji...@apache.org> on 2012/12/12 09:35:21 UTC
[jira] [Commented] (STANBOL-833) Feedbacks on SolrStoreImpl
[ https://issues.apache.org/jira/browse/STANBOL-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529748#comment-13529748 ]
Suat Gonul commented on STANBOL-833:
------------------------------------
Thanks for the patch Florent. I agree with all of your modifications, so applied the patch as it is.
> Feedbacks on SolrStoreImpl
> --------------------------
>
> Key: STANBOL-833
> URL: https://issues.apache.org/jira/browse/STANBOL-833
> Project: Stanbol
> Issue Type: Bug
> Components: Contenthub
> Reporter: Florent ANDRE
> Attachments: Stanbol-833.patch
>
>
> Here come a patch for review, as I may miss some things.
> 3 modifications here :
> 1) Move the updateEnhancementGraph(ci); call from "enhance" to "put", as updateEnhancementGraph(ci); fit better in "put" as it's the clerezza graph counterpart of Solr save.
> So now, "enhance" only enhance and "put" save your CI (in the clerezza graph and in the Solr Core).
> 2) Change a triple iteration to the build-in graph.addAll() function. There is a special reason to use an iteration here ?
> 3) Remove code duplication in the "put(ContentItem ci)" and "put(ContentItem ci, String ldProgramName)"
> Patch attached for comments.
> Thanks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira