You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/03/25 22:02:29 UTC
Review Request 32495: Fixed a regression caused by multiple cgroups
base hierarchy detection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Ian Downes.
Bugs: MESOS-2548
https://issues.apache.org/jira/browse/MESOS-2548
Repository: mesos
Description
-------
Fixed a regression caused by multiple cgroups base hierarchy detection.
Diffs
-----
src/tests/mesos.cpp dc2a906a57b9abace4713aea8b0a47fec1c1a8a4
Diff: https://reviews.apache.org/r/32495/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 32495: Fixed a regression caused by multiple
cgroups base hierarchy detection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495/#review77797
-----------------------------------------------------------
Ship it!
Thanks!
- Ben Mahler
On March 25, 2015, 9:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32495/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 9:12 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Bugs: MESOS-2548
> https://issues.apache.org/jira/browse/MESOS-2548
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a regression caused by multiple cgroups base hierarchy detection.
>
> The previous way of getting base hierarchy is not reliable in the case of cgroup co-mounts and symlinks (e.g. systemd). For example, you may see the following layout:
> ```
> /sys/fs/cgroup/cpu,cpuacct
> /sys/fs/cgroup/cpu -> /sys/fs/cgroup/cpu,cpuacct
> /sys/fs/cgroup/cpuacct -> /sys/fs/cgroup/cpu,cpuacct
> ```
>
> For subsystem 'cpuacct', the current code will report the base hierarchy to be '/sys/fs/cgroup/cpu,'.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp dc2a906a57b9abace4713aea8b0a47fec1c1a8a4
>
> Diff: https://reviews.apache.org/r/32495/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32495: Fixed a regression caused by multiple
cgroups base hierarchy detection.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495/
-----------------------------------------------------------
(Updated March 25, 2015, 9:12 p.m.)
Review request for mesos, Ben Mahler and Ian Downes.
Bugs: MESOS-2548
https://issues.apache.org/jira/browse/MESOS-2548
Repository: mesos
Description (updated)
-------
Fixed a regression caused by multiple cgroups base hierarchy detection.
The previous way of getting base hierarchy is not reliable in the case of cgroup co-mounts and symlinks (e.g. systemd). For example, you may see the following layout:
```
/sys/fs/cgroup/cpu,cpuacct
/sys/fs/cgroup/cpu -> /sys/fs/cgroup/cpu,cpuacct
/sys/fs/cgroup/cpuacct -> /sys/fs/cgroup/cpu,cpuacct
```
For subsystem 'cpuacct', the current code will report the base hierarchy to be '/sys/fs/cgroup/cpu,'.
Diffs
-----
src/tests/mesos.cpp dc2a906a57b9abace4713aea8b0a47fec1c1a8a4
Diff: https://reviews.apache.org/r/32495/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 32495: Fixed a regression caused by multiple
cgroups base hierarchy detection.
Posted by Jie Yu <yu...@gmail.com>.
> On March 25, 2015, 9:07 p.m., Ben Mahler wrote:
> > Mind adding how this fixes the issue to the description?
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495/#review77795
-----------------------------------------------------------
On March 25, 2015, 9:12 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32495/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 9:12 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Bugs: MESOS-2548
> https://issues.apache.org/jira/browse/MESOS-2548
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a regression caused by multiple cgroups base hierarchy detection.
>
> The previous way of getting base hierarchy is not reliable in the case of cgroup co-mounts and symlinks (e.g. systemd). For example, you may see the following layout:
> ```
> /sys/fs/cgroup/cpu,cpuacct
> /sys/fs/cgroup/cpu -> /sys/fs/cgroup/cpu,cpuacct
> /sys/fs/cgroup/cpuacct -> /sys/fs/cgroup/cpu,cpuacct
> ```
>
> For subsystem 'cpuacct', the current code will report the base hierarchy to be '/sys/fs/cgroup/cpu,'.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp dc2a906a57b9abace4713aea8b0a47fec1c1a8a4
>
> Diff: https://reviews.apache.org/r/32495/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 32495: Fixed a regression caused by multiple
cgroups base hierarchy detection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495/#review77795
-----------------------------------------------------------
Mind adding how this fixes the issue to the description?
- Ben Mahler
On March 25, 2015, 9:02 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32495/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 9:02 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Bugs: MESOS-2548
> https://issues.apache.org/jira/browse/MESOS-2548
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a regression caused by multiple cgroups base hierarchy detection.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp dc2a906a57b9abace4713aea8b0a47fec1c1a8a4
>
> Diff: https://reviews.apache.org/r/32495/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>