[GitHub] [iceberg] rdblue commented on a diff in pull request #5318: Flink: bridge the gap btw FlinkSource and IcebergSource (FLIP-27) and…

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5318:
URL: https://github.com/apache/iceberg/pull/5318#discussion_r927812551


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -39,7 +43,10 @@
 import org.apache.flink.table.expressions.ResolvedExpression;
 import org.apache.flink.table.types.DataType;
 import org.apache.iceberg.expressions.Expression;
-import org.apache.iceberg.flink.source.FlinkSource;
+import org.apache.iceberg.flink.FlinkConfigOptions;
+import org.apache.iceberg.flink.FlinkFilters;
+import org.apache.iceberg.flink.TableLoader;
+import org.apache.iceberg.flink.source.assigner.SplitAssignerType;

Review Comment:
   Should we mark this class internal so people don't use it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org