You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/09/20 23:30:40 UTC
Review Request 14257: [OOZIE-1547] Change Coordinator SELECT query to fetch
only necessary columns and consolidate JPA Executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14257/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1547
https://issues.apache.org/jira/browse/OOZIE-1547
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1547
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525146
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetPendingJPAExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1525146
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1525146
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525146
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1525146
Diff: https://reviews.apache.org/r/14257/diff/
Testing
-------
ran all test cases
Thanks,
Ryota Egashira
Re: Review Request 14257: [OOZIE-1547] Change Coordinator SELECT query to
fetch only necessary columns and consolidate JPA Executors
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14257/#review26306
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Sept. 20, 2013, 9:30 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14257/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2013, 9:30 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1547
> https://issues.apache.org/jira/browse/OOZIE-1547
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1547
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525146
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525146
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1525146
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1525146
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java 1525146
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1525146
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1525146
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1525146
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1525146
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525146
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525146
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetPendingJPAExecutor.java 1525146
> trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1525146
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1525146
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525146
> trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1525146
>
> Diff: https://reviews.apache.org/r/14257/diff/
>
>
> Testing
> -------
>
> ran all test cases
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 14257: [OOZIE-1547] Change Coordinator SELECT query to
fetch only necessary columns and consolidate JPA Executors
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14257/
-----------------------------------------------------------
(Updated Sept. 21, 2013, 12:35 a.m.)
Review request for oozie.
Changes
-------
fixed minor issues.
Bugs: OOZIE-1547
https://issues.apache.org/jira/browse/OOZIE-1547
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1547
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525146
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsKillXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetPendingJPAExecutor.java 1525146
trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java 1525146
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1525146
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsCountNotForPurgeFromParentIdJPAExecutor.java 1525146
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525146
trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1525146
Diff: https://reviews.apache.org/r/14257/diff/
Testing
-------
ran all test cases
Thanks,
Ryota Egashira