[GitHub] [superset] geido commented on a diff in pull request #23543: fix: Hide FilterBar for Reports

["geido (via GitHub)" <gi...@apache.org>]

geido commented on code in PR #23543:
URL: https://github.com/apache/superset/pull/23543#discussion_r1154686369


##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -655,18 +658,17 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
                 >
                   <StickyPanel ref={containerRef} width={filterBarWidth}>
                     <ErrorBoundary>
-                      {!isReport && (

Review Comment:
   I think they should stay as it keeps the paddings that are also present in the right side
   
   <img width="1792" alt="Screenshot 2023-03-31 at 18 37 19" src="https://user-images.githubusercontent.com/60598000/229179316-1cb0cb7d-ec84-4c03-852b-497cfbf5195e.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org