You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "hexagonhill (via GitHub)" <gi...@apache.org> on 2024/09/17 07:58:53 UTC
[PR] [C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion [avro]
hexagonhill opened a new pull request, #3166:
URL: https://github.com/apache/avro/pull/3166
Example of changed code to remove error.
`int32_t checksum = crc();`
to
`auto checksum = crc();`
`error: conversion from ‘boost::crc_optimal<32, 79764919, 4294967295, 4294967295, true, true>::value_type’ {aka ‘long unsigned int’} to ‘uint32_t’ {aka ‘unsigned int’} may change value [-Werror=conversion]`
Further errors not related to avro cmake but using a meson build port was missing <algorithm> header in some files such that std::find and std::find_if could not be found. Thought to include them in PR.
These changes passed ./build.sh test
Thanks for the code!
Sorry for the informal request a bit busy but wanted to give back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion [avro]
Posted by "hexagonhill (via GitHub)" <gi...@apache.org>.
hexagonhill commented on code in PR #3166:
URL: https://github.com/apache/avro/pull/3166#discussion_r1764370971
##########
lang/c++/meson.build:
##########
@@ -0,0 +1,150 @@
+project('avro-cpp', 'cpp', version: '1.0',
Review Comment:
Sorry. I removed it. I didn't know PR would follow so to speak further commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #3166:
URL: https://github.com/apache/avro/pull/3166#issuecomment-2367918847
Thank you, @hexagonhill !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #3166:
URL: https://github.com/apache/avro/pull/3166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion [avro]
Posted by "Gerrit0 (via GitHub)" <gi...@apache.org>.
Gerrit0 commented on code in PR #3166:
URL: https://github.com/apache/avro/pull/3166#discussion_r1764256842
##########
lang/c++/meson.build:
##########
@@ -0,0 +1,150 @@
+project('avro-cpp', 'cpp', version: '1.0',
Review Comment:
I think including this without any build tooling to ensure it remains up to date is a really bad idea. It will immediately become out of date when someone next updates the CMakeLists file...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] g++ (GCC) 14.2.1 20240910 fails to compile due to -Werror=conversion [avro]
Posted by "Gerrit0 (via GitHub)" <gi...@apache.org>.
Gerrit0 commented on code in PR #3166:
URL: https://github.com/apache/avro/pull/3166#discussion_r1764257467
##########
lang/c++/meson.build:
##########
@@ -0,0 +1,150 @@
+project('avro-cpp', 'cpp', version: '1.0',
Review Comment:
If adding said tooling isn't trivial, or maybe even if it is, splitting into a second PR to make it easier to merge isn't a bad idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org