You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/22 14:01:14 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
HeartSaVioR opened a new pull request #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979
### What changes were proposed in this pull request?
This patch addresses review comments in #26960 (https://github.com/apache/spark/pull/26960#discussion_r360661930 / https://github.com/apache/spark/pull/26960#discussion_r360661947) which were not addressed in the patch. Addressing these review comments will let the code less dependent on actual implementation as it only relies on `Time` interface.
### Why are the changes needed?
These were review comments in previous PR and they bring actual benefit though they're minors.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568578763
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115648/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568576314
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568575565
**[Test build #115648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115648/testReport)** for PR 26979 at commit [`fbde6ac`](https://github.com/apache/spark/commit/fbde6ac47ca2582fb3ccf4cba3d2b78bc34a7ddc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568576320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20447/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568576320
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20447/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568637453
Thanks all for reviewing and merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568494522
@shaneknapp any chance of kicking them? I'm seeing all the PR builders not respond
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568632476
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568578758
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568390232
Looks like there's some issue on AMPLab Jenkins server. Would the situation be expected to take longer as weekend & Xmas week (year end as well)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568576314
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568575565
**[Test build #115648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115648/testReport)** for PR 26979 at commit [`fbde6ac`](https://github.com/apache/spark/commit/fbde6ac47ca2582fb3ccf4cba3d2b78bc34a7ddc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568603330
Finally the build ran and passed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568578758
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568290818
Thank you for making a follow-up. Let's see the Jenkins result (after it become healthy back.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568578763
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115648/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568265814
cc. @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568385294
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26979:
[SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka
Time interface
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26979: [SPARK-28144][SPARK-29294][SS][FOLLOWUP] Use SystemTime defined in Kafka Time interface
URL: https://github.com/apache/spark/pull/26979#issuecomment-568578695
**[Test build #115648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115648/testReport)** for PR 26979 at commit [`fbde6ac`](https://github.com/apache/spark/commit/fbde6ac47ca2582fb3ccf4cba3d2b78bc34a7ddc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org