You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "sam-byng (via GitHub)" <gi...@apache.org> on 2023/04/26 14:18:48 UTC

[GitHub] [incubator-pekko] sam-byng opened a new pull request, #300: GH PR Workflow: Separate validateCompile step from validatePullRequest

sam-byng opened a new pull request, #300:
URL: https://github.com/apache/incubator-pekko/pull/300

   Currently the PR workflow 'Build / Test' job has a single step validatePullRequest that both compiles and then tests the changes. This takes 30 minutes and is very verbose -- it is difficult to see exactly where a failure is originating.
   
   This PR separating compile and test: This will make the source of errors in steps clearer, without adding any extra pipeline time. (Steps in github jobs are dependent on one another, so the build files can be passed onto prValidation without the need for PR validation to compile again)
   
   On the overall issue: I think next steps should be to extract test logs into their own short-lifetime artifact files and reduce the CI logs to only show failing tests. Will follow up with a PR on that if people think that's a good idea.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] pjfanning commented on pull request #300: Improve PR Workflow: Separate the validateCompile step from validatePullRequest

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #300:
URL: https://github.com/apache/incubator-pekko/pull/300#issuecomment-1704072609

   merged - if there are build issues, we can fix them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #300: Improve PR Workflow: Separate the validateCompile step from validatePullRequest

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #300:
URL: https://github.com/apache/incubator-pekko/pull/300#issuecomment-1704074476

   I think its legitimate to cherry pick this onto the `1.0.x` branch, @sam-byng Do you want to do this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] pjfanning merged pull request #300: Improve PR Workflow: Separate the validateCompile step from validatePullRequest

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #300:
URL: https://github.com/apache/incubator-pekko/pull/300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on pull request #300: Improve PR Workflow: Separate the validateCompile step from validatePullRequest

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #300:
URL: https://github.com/apache/incubator-pekko/pull/300#issuecomment-1704071219

   @pjfanning What's option here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on pull request #300: Improve PR Workflow: Separate the validateCompile step from validatePullRequest

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #300:
URL: https://github.com/apache/incubator-pekko/pull/300#issuecomment-1704073832

   @sam-byng Merged, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #300: Improve PR Workflow: Separate the validateCompile step from validatePullRequest

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #300:
URL: https://github.com/apache/incubator-pekko/pull/300#issuecomment-1706271252

   Cherry pick PR against `1.0.x` made at https://github.com/apache/incubator-pekko/pull/630


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org