You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Manikumar <ma...@gmail.com> on 2018/06/26 16:34:34 UTC
[DISCUSS] KIP-322: Return new error code for DeleteTopics API when
topic deletion disabled.
Hi all,
I have created a minor KIP to return new error code for DeleteTopics API
when topic deletion disabled.
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87295558
Please take a look.
Thanks,
Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API
when topic deletion disabled.
Posted by Manikumar <ma...@gmail.com>.
Since this is a minor KIP, If there are no concerns I will start voting
thread.
On Wed, Jun 27, 2018 at 2:24 PM Ted Yu <yu...@gmail.com> wrote:
> bq. set the serialVersionUID = 1L in Kafka exception classes
>
> Indeed. Should have checked earlier.
>
> On Wed, Jun 27, 2018 at 1:38 AM, Manikumar <ma...@gmail.com>
> wrote:
>
> > Hi,
> >
> > Thanks for the review.
> >
> >
> > > nit: you are going to fill in an actual value below in your PR, right ?
> > > private static final long serialVersionUID = 1L;
> > >
> > >
> > We normally set the serialVersionUID = 1L in Kafka exception classes.
> >
> > In Motivation, please mention the IllegalStateException scenario.
> > >
> >
> > IllegalStateException mentioned in the JIRA is specific to user
> > implementaion.
> > Main issue is we wont get response form the server. In this case, admin
> > client times out the requests.
> >
>
Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API
when topic deletion disabled.
Posted by Ted Yu <yu...@gmail.com>.
bq. set the serialVersionUID = 1L in Kafka exception classes
Indeed. Should have checked earlier.
On Wed, Jun 27, 2018 at 1:38 AM, Manikumar <ma...@gmail.com>
wrote:
> Hi,
>
> Thanks for the review.
>
>
> > nit: you are going to fill in an actual value below in your PR, right ?
> > private static final long serialVersionUID = 1L;
> >
> >
> We normally set the serialVersionUID = 1L in Kafka exception classes.
>
> In Motivation, please mention the IllegalStateException scenario.
> >
>
> IllegalStateException mentioned in the JIRA is specific to user
> implementaion.
> Main issue is we wont get response form the server. In this case, admin
> client times out the requests.
>
Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API
when topic deletion disabled.
Posted by Manikumar <ma...@gmail.com>.
Hi,
Thanks for the review.
> nit: you are going to fill in an actual value below in your PR, right ?
> private static final long serialVersionUID = 1L;
>
>
We normally set the serialVersionUID = 1L in Kafka exception classes.
In Motivation, please mention the IllegalStateException scenario.
>
IllegalStateException mentioned in the JIRA is specific to user
implementaion.
Main issue is we wont get response form the server. In this case, admin
client times out the requests.
Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API
when topic deletion disabled.
Posted by Ted Yu <yu...@gmail.com>.
Looks good overall.
nit: you are going to fill in an actual value below in your PR, right ?
private static final long serialVersionUID = 1L;
In Motivation, please mention the IllegalStateException scenario.
On Tue, Jun 26, 2018 at 9:34 AM, Manikumar <ma...@gmail.com>
wrote:
> Hi all,
>
> I have created a minor KIP to return new error code for DeleteTopics API
> when topic deletion disabled.
>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87295558
>
> Please take a look.
>
> Thanks,
>