You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2022/10/24 06:22:51 UTC
[GitHub] [ambari] kevinw66 opened a new pull request, #3431: AMBARI-25198. MYSQL connector exception while upgrading Ambari
kevinw66 opened a new pull request, #3431:
URL: https://github.com/apache/ambari/pull/3431
## What changes were proposed in this pull request?
Forward port commit [ed80f7a](https://github.com/apache/ambari/commit/ed80f7add8a4cc02192671647d7cda2c8f938797) on branch-2.7
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 merged pull request #3431: AMBARI-25198. MYSQL connector exception while upgrading Ambari
Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #3431:
URL: https://github.com/apache/ambari/pull/3431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on a diff in pull request #3431: AMBARI-25198. MYSQL connector exception while upgrading Ambari
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #3431:
URL: https://github.com/apache/ambari/pull/3431#discussion_r1012675454
##########
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java:
##########
@@ -76,6 +77,11 @@
@Singleton
public class DBAccessorImpl implements DBAccessor {
private static final Logger LOG = LoggerFactory.getLogger(DBAccessorImpl.class);
+ public static final String USER = "user";
+ public static final String PASSWORD = "password";
+ public static final String NULL_CATALOG_MEANS_CURRENT = "nullCatalogMeansCurrent";
+ public static final String TRUE = "true";
+ public static final int SUPPORT_CONNECTOR_VERSION = 5;
Review Comment:
Yep!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] virajjasani commented on a diff in pull request #3431: AMBARI-25198. MYSQL connector exception while upgrading Ambari
Posted by GitBox <gi...@apache.org>.
virajjasani commented on code in PR #3431:
URL: https://github.com/apache/ambari/pull/3431#discussion_r1008937587
##########
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java:
##########
@@ -76,6 +77,11 @@
@Singleton
public class DBAccessorImpl implements DBAccessor {
private static final Logger LOG = LoggerFactory.getLogger(DBAccessorImpl.class);
+ public static final String USER = "user";
+ public static final String PASSWORD = "password";
+ public static final String NULL_CATALOG_MEANS_CURRENT = "nullCatalogMeansCurrent";
+ public static final String TRUE = "true";
+ public static final int SUPPORT_CONNECTOR_VERSION = 5;
Review Comment:
For the forward-port purpose, this is good but otherwise we can make them all private in separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org