You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2021/10/26 07:18:50 UTC

[kudu-CR] [encryption] Add encryption support to Env

Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17251 )

Change subject: [encryption] Add encryption support to Env
......................................................................

[encryption] Add encryption support to Env

This commit introduces reading and writing encrypted files through Env.
At this stage, encryption is not usable, as it uses a static dummy key.

Originally, I wanted to use a simple Caesar's cipher like ROT13 until
the rest of the key infra is in place, but then I decided this proof of
concept implementation should also prove that CTR, which is our chosen
mode of operation[1] works for our access patterns, so I ended up using
OpenSSL even in this proof of concept, albeit with a static key and
key size.

[1] https://s.apache.org/kudu-atrest-enc-design

Change-Id: Id5a81b5736a0c1970818dbbc4a234480476b8d41
Reviewed-on: http://gerrit.cloudera.org:8080/17251
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/coding-inl.h
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
M src/kudu/util/openssl_util.h
5 files changed, 321 insertions(+), 36 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5a81b5736a0c1970818dbbc4a234480476b8d41
Gerrit-Change-Number: 17251
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)