You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/12/11 07:21:58 UTC
[GitHub] codecov-io edited a comment on issue #508: SCB-1053 Add instances
request struct
codecov-io edited a comment on issue #508: SCB-1053 Add instances request struct
URL: https://github.com/apache/servicecomb-service-center/pull/508#issuecomment-445459421
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=h1) Report
> Merging [#508](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/fad2b5811f0476069fdfd68e65d14e7b2c81941a?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `68.7%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #508 +/- ##
=========================================
+ Coverage 59.31% 59.42% +0.1%
=========================================
Files 166 166
Lines 13944 14036 +92
=========================================
+ Hits 8271 8341 +70
- Misses 5088 5108 +20
- Partials 585 587 +2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `51.91% <100%> (ø)` | :arrow_up: |
| [server/service/instance\_validator.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | :arrow_up: |
| [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.13% <67.14%> (-0.12%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: |
| [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `94.87% <0%> (-1.29%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: |
| [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/508/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=footer). Last update [fad2b58...9bfce2f](https://codecov.io/gh/apache/servicecomb-service-center/pull/508?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services