[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4158: [RoutineLoad] Support modify routine load job

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #4158:
URL: https://github.com/apache/incubator-doris/pull/4158#discussion_r464287690



##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -1397,4 +1401,36 @@ public void readFields(DataInput in) throws IOException {
             throw new IOException("error happens when parsing create routine load stmt: " + origStmt, e);
         }
     }
+
+    abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException;
+
+    abstract public void replayModifyProperties(AlterRoutineLoadJobOperationLog log);

Review comment:
       Same as above.

##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -1397,4 +1401,36 @@ public void readFields(DataInput in) throws IOException {
             throw new IOException("error happens when parsing create routine load stmt: " + origStmt, e);
         }
     }
+
+    abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException;

Review comment:
       The job properties maybe could be modified in here instead of the subclass  `KafkaRoutineLoad`.

##########
File path: fe/fe-core/src/main/cup/sql_parser.cup
##########
@@ -722,11 +724,26 @@ alter_stmt ::=
     {:
         RESULT = new AlterDatabaseQuotaStmt(dbName, QuotaType.REPLICA, String.valueOf(number));
     :}
-
     | KW_ALTER KW_DATABASE ident:dbName KW_RENAME ident:newDbName
     {:
         RESULT = new AlterDatabaseRename(dbName, newDbName);
     :}
+    | KW_ALTER KW_ROUTINE KW_LOAD job_label:jobLabel opt_properties:jobProperties

Review comment:
       Maybe `KW_ALTER KW_ROUTINE KW_LOAD KW_FOR job_label:jobLabel ` is better. The other routine load stmt also has KW_FOR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org