[GitHub] [cloudstack] anuragaw commented on a change in pull request #3268: Support sort_key for vpc_offerings table

[GitBox <gi...@apache.org>]

anuragaw commented on a change in pull request #3268: Support sort_key for vpc_offerings table
URL: https://github.com/apache/cloudstack/pull/3268#discussion_r291553014
 
 

 ##########
 File path: api/src/main/java/com/cloud/network/vpc/VpcProvisioningService.java
 ##########
 @@ -41,12 +43,9 @@ public VpcOffering createVpcOffering(String name, String displayText, List<Strin
     public boolean deleteVpcOffering(long offId);
 
     /**
-     * @param vpcOffId
-     * @param vpcOfferingName
-     * @param displayText
-     * @param state
+     * @param vpcOfferingCmd
      * @return
      */
-    public VpcOffering updateVpcOffering(long vpcOffId, String vpcOfferingName, String displayText, String state);
+    public VpcOffering updateVpcOffering(final UpdateVPCOfferingCmd vpcOfferingCmd);
 
 Review comment:
   Pretty sure there wasn't any internal plugin Daan, but I think it's a good practice in general. Doing the change now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services