You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/03 17:44:51 UTC

[GitHub] haojin2 commented on a change in pull request #12017: Fix flaky tests for test_squared_hinge_loss

haojin2 commented on a change in pull request #12017: Fix flaky tests for test_squared_hinge_loss
URL: https://github.com/apache/incubator-mxnet/pull/12017#discussion_r207618505
 
 

 ##########
 File path: tests/python/unittest/test_loss.py
 ##########
 @@ -310,7 +310,9 @@ def test_hinge_loss():
     assert mod.score(data_iter, eval_metric=mx.metric.Loss())[0][1] < 0.05
 
 
-@with_seed(1234)
+# @zachgk: Getting ride of fixed seed as flakiness could not be reproduced,
+# tracked at https://github.com/apache/incubator-mxnet/issues/11702
 
 Review comment:
   Feel free to remove the 2 comment lines and simply link the issue in your PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services