You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/02 05:34:00 UTC
[GitHub] [netbeans] tmysik commented on a change in pull request #3549: [NETBEANS-6177] Fix an issue the stop command is not sent
tmysik commented on a change in pull request #3549:
URL: https://github.com/apache/netbeans/pull/3549#discussion_r797287519
##########
File path: php/php.dbgp/src/org/netbeans/modules/php/dbgp/DebugSession.java
##########
@@ -124,6 +125,14 @@ public void run() {
} catch (Throwable e) {
log(e, Level.SEVERE);
}
+ if (canceled) {
+ synchronized (commands) {
Review comment:
The change looks good to me. However, the threading in this class is not documented and is not clear to me - I can see no synchronization of `commands` in `preprocess()` method, for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists