You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/02/22 07:05:19 UTC

[GitHub] [dubbo] guohao opened a new pull request #9708: [3.0-Triple] A reactor for better abstraction and futher stub api

guohao opened a new pull request #9708:
URL: https://github.com/apache/dubbo/pull/9708


   ## What is the purpose of the change
   
   1. Provide a better api abstraction for compiled stub and full reactive support
   2. Better readability for develop
   3. Better performance
   4. Basic reactive support (`requestN()`)
   5. A better error handling model and more meaningful error description
   
   ## Brief changelog
   - Abstraction `Call` model to represent a stream/unary call.
   - Try use specific Listener instead of generic `StreamObserver` for better readability
   - Move all stream operations from netty eventloop to user executor to improve performance
   
   ## Verifying this change
   Run UT and IT
   
   <!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
   - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
   - [x] GitHub Actions works fine on your own branch.
   - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] codecov-commenter commented on pull request #9708: [3.0-Triple] A reactor for better abstraction and futher stub api

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9708:
URL: https://github.com/apache/dubbo/pull/9708#issuecomment-1047519335


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9708](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ab6521) into [3.0](https://codecov.io/gh/apache/dubbo/commit/cace611778aff5699f791bb75a3a463306d04b82?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cace611) will **decrease** coverage by `0.05%`.
   > The diff coverage is `56.32%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9708/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9708      +/-   ##
   ============================================
   - Coverage     65.68%   65.63%   -0.06%     
   - Complexity      295      297       +2     
   ============================================
     Files          1192     1205      +13     
     Lines         52187    52124      -63     
     Branches       7925     7913      -12     
   ============================================
   - Hits          34277    34209      -68     
   + Misses        14216    14214       -2     
   - Partials       3694     3701       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...bbo/rpc/protocol/tri/CancelableStreamObserver.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2FuY2VsYWJsZVN0cmVhbU9ic2VydmVyLmphdmE=) | `20.00% <0.00%> (-23.75%)` | :arrow_down: |
   | [...g/apache/dubbo/rpc/protocol/tri/ClassLoadUtil.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xhc3NMb2FkVXRpbC5qYXZh) | `33.33% <ø> (ø)` | |
   | [...he/dubbo/rpc/protocol/tri/SingleProtobufUtils.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvU2luZ2xlUHJvdG9idWZVdGlscy5qYXZh) | `80.00% <ø> (ø)` | |
   | [...pache/dubbo/rpc/protocol/tri/TripleHeaderEnum.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlSGVhZGVyRW51bS5qYXZh) | `91.42% <ø> (-2.86%)` | :arrow_down: |
   | [...che/dubbo/rpc/protocol/tri/TriplePathResolver.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlUGF0aFJlc29sdmVyLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...o/rpc/protocol/tri/command/HeaderQueueCommand.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvY29tbWFuZC9IZWFkZXJRdWV1ZUNvbW1hbmQuamF2YQ==) | `80.00% <ø> (-8.89%)` | :arrow_down: |
   | [...rpc/protocol/tri/command/TextDataQueueCommand.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvY29tbWFuZC9UZXh0RGF0YVF1ZXVlQ29tbWFuZC5qYXZh) | `62.50% <ø> (ø)` | |
   | [.../rpc/protocol/tri/stream/ClientStreamListener.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvc3RyZWFtL0NsaWVudFN0cmVhbUxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...o/rpc/protocol/tri/transport/GracefulShutdown.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L0dyYWNlZnVsU2h1dGRvd24uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...pc/protocol/tri/transport/H2TransportListener.java](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvdHJhbnNwb3J0L0gyVHJhbnNwb3J0TGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [90 more](https://codecov.io/gh/apache/dubbo/pull/9708/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cace611...9ab6521](https://codecov.io/gh/apache/dubbo/pull/9708?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] guohao merged pull request #9708: [3.0-Triple] A reactor for better abstraction and futher stub api

Posted by GitBox <gi...@apache.org>.
guohao merged pull request #9708:
URL: https://github.com/apache/dubbo/pull/9708


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org