[GitHub] [spark] Yikun commented on a change in pull request #35345: [SPARK-37145][K8S] Add KubernetesCustom[Driver/Executor]FeatureConfigStep developer api

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #35345:
URL: https://github.com/apache/spark/pull/35345#discussion_r796430078



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
##########
@@ -381,4 +382,13 @@ object KubernetesUtils extends Logging {
       }
     }
   }
+
+  // Load and init custom feature step according to `className` and `conf`
+  // This method is used by `KubernetesDriverBuilder` and `KubernetesExecutorBuilder`
+  @Since("3.3.0")
+  def loadFeatureStep(conf: KubernetesConf, className: String): KubernetesFeatureConfigStep = {

Review comment:
       @attilapiros I have updated the PR, test and desciption as your  suggestion, it would be good if you can get time to review again. : ) Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org