You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/07/11 09:38:03 UTC

[GitHub] [echarts] MNHarshitha opened a new issue, #17350: Series symbol rotation is not respected in legends[Bug]

MNHarshitha opened a new issue, #17350:
URL: https://github.com/apache/echarts/issues/17350

   ### Version
   
   5.3.0
   
   ### Link to Minimal Reproduction
   
   https://codepen.io/Harshitha19/pen/RwMRxEd
   
   ### Steps to Reproduce
   
   1. Create a scatter series with different symbols, symbolRotation, and enable legends.
   2. Observe that series symbol rotation is not being inherited by the legends symbol.
   
   ### Current Behavior
   
   Series symbol rotation is not inherited by the legends symbol.
   ![image](https://user-images.githubusercontent.com/97500674/178235543-8e31d32a-6a96-4944-87c0-7ddbc7e1c80d.png)
   
   
   ### Expected Behavior
   
   Legends symbol should inherit the series symbol rotation.
   
   ### Environment
   
   ```markdown
   - OS:
   - Browser:
   - Framework:
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] jiawulin001 commented on issue #17350: [Bug] Series symbol rotation is not respected in legends

Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on issue #17350:
URL: https://github.com/apache/echarts/issues/17350#issuecomment-1181271755

   ## Conclusion
   Adding a method `getLegendIcon()` to scatterSeriesModel can solve this problem. Submitting a PR to solve this.
   
   ## Problem location
   <details>
   <summary>More info</summary>
   
   Interesting enough, I've found that line series would not have such problem becasue of a judgement here:
   https://github.com/apache/echarts/blob/add11459ee43a56f7ff5b300c76b3f801f59f3c6/src/component/legend/LegendView.ts#L371
   Since the method `getLegendIcon()` exists only in `LineSeriesModel` and `MapSeries`, the judgement is not satisfied for scatter chart so the icons styles are not inheritated.
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] RavalikaP commented on issue #17350: [Bug] Series symbol rotation is not respected in legends

Posted by GitBox <gi...@apache.org>.
RavalikaP commented on issue #17350:
URL: https://github.com/apache/echarts/issues/17350#issuecomment-1243342300

   Hi, This is something we are also looking for the solution. Can I get the status or any suggestions/ workaround in this regard would be much appreciated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org